Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -Wnon-virtual-dtor for classes derived from boost::system::error_category #339

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Commits on Apr 5, 2020

  1. Disable -Wnon-virtual-dtor for classes derived from boost::system::er…

    …ror_category
    
    Compiler warnings for non-virtual destructors are disabled for
    boost::system::error_category but the issue also affects all derived
    classes.
    
      error: base class ‘class boost::system::error_category’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
       class netdb_category : public boost::system::error_category
             ^~~~~~~~~~~~~~
      error: ‘class boost::asio::error::detail::netdb_category’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
    
      error: base class ‘class boost::system::error_category’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
       class addrinfo_category : public boost::system::error_category
             ^~~~~~~~~~~~~~~~~
      error: ‘class boost::asio::error::detail::addrinfo_category’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
    
      error: base class ‘class boost::system::error_category’ has accessible non-virtual destructor [-Werror=non-virtual-dtor]
       class misc_category : public boost::system::error_category
             ^~~~~~~~~~~~~
      error: ‘class boost::asio::error::detail::misc_category’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
    
    Disable -Wnon-virtual-dtor in the same way that Boost.System does.
    nomis committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    09460ec View commit details
    Browse the repository at this point in the history