Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on Boost::align #384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

ecatmur
Copy link
Contributor

@ecatmur ecatmur commented Oct 29, 2021

it is required on Windows (from boost/asio/detail/memory.hpp), since MSVC doesn't have std::aligned_alloc

The source code in this repository is generated from an upstream repository at https://github.com/chriskohlhoff/asio.

Please consider raising new pull requests at https://github.com/chriskohlhoff/asio/pulls.

it is required on Windows (from boost/asio/detail/memory.hpp), since MSVC doesn't have std::aligned_alloc
@Lastique
Copy link
Member

Lastique commented Oct 29, 2021

This is also needed on Linux.

Ping @pdimov. Is CMakeLists.txt maintained locally by Boost? Looks like it's not part of the upstream ASIO.

@pdimov
Copy link
Member

pdimov commented Oct 29, 2021

No idea who is maintaining the CML file. :-) The PR seems correct to me.

@pdimov
Copy link
Member

pdimov commented Oct 30, 2021

But I can merge this if Chris wants us to maintain the CML. Chris?

@chriskohlhoff
Copy link
Collaborator

Commit applied.
Are there automated tests of this cmake stuff somewhere?

@pdimov
Copy link
Member

pdimov commented Nov 1, 2021

There are some automated tests for Boost as a whole (whether it builds and installs with CMake), but they can't catch this. There are no outside tests that test every library one by one; such tests need to be enabled in the library repos.

Example workflows are this one that tests use with add_subdirectory and this one that tests use after installation.

@pdimov
Copy link
Member

pdimov commented Nov 1, 2021

An easier approach for libraries such as Asio where CMakeLists.txt is generated by boostdep --cmake asio is to have a ci.yml job that compares the current contents to the generated output and fails if they don't match. Although this will occasionally fire when I make changes to boostdep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants