Skip to content

Commit

Permalink
Fixes blink configuration warnings due to disabled features.
Browse files Browse the repository at this point in the history
  • Loading branch information
mkarolin committed Sep 18, 2024
1 parent bfd6e62 commit 62158c6
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/feature_defaults_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ TEST(FeatureDefaultsTest, DisabledFeatures) {
&features::kPrivacyGuidePreloadAndroid,
#endif
&features::kPrivacySandboxAdsAPIsOverride,
&features::kPrivacySandboxAdsAPIsM1Override,
#if !BUILDFLAG(IS_ANDROID)
&features::kReportPakFileIntegrity,
#endif
Expand Down
2 changes: 2 additions & 0 deletions chromium_src/content/common/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
namespace features {

OVERRIDE_FEATURE_DEFAULT_STATES({{
// This feature should not be enabled when kFencedFrames is disabled.
{kPrivacySandboxAdsAPIsM1Override, base::FEATURE_DISABLED_BY_DEFAULT},
{kResourceTimingForCancelledNavigationInFrame,
base::FEATURE_DISABLED_BY_DEFAULT},
{kServiceWorkerAutoPreload, base::FEATURE_DISABLED_BY_DEFAULT},
Expand Down
3 changes: 3 additions & 0 deletions renderer/brave_content_renderer_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ void BraveContentRendererClient::
SetRuntimeFeaturesDefaultsBeforeBlinkInitialization();

blink::WebRuntimeFeatures::EnableFledge(false);
// Disable topics APIs because kBrowsingTopics feature is disabled
blink::WebRuntimeFeatures::EnableTopicsAPI(false);
blink::WebRuntimeFeatures::EnableTopicsDocumentAPI(false);
blink::WebRuntimeFeatures::EnableWebGPUExperimentalFeatures(false);
blink::WebRuntimeFeatures::EnableWebNFC(false);

Expand Down
72 changes: 71 additions & 1 deletion test/filters/browser_tests.filter
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@
-ExternalProtocolHandlerSandboxFencedFrameBrowserTest.SandboxAllowTopNavigationByUserActivationWithGestureInFencedFrame
-PrivacySandboxSettingsAdsApisFlagBrowserTest.FollowsOverrideBehavior
-SharedStorageChromeContextOriginByDefaultDisabledBrowserTest.*
-SharedStorageChromeCrossOriginScriptDisabledBrowserTest.AddModule_CrossOriginScriptError
-SharedStorageExtensionBrowserTest.*
-SharedStorageFencedFrameChromeBrowserTest.*

Expand Down Expand Up @@ -831,12 +832,26 @@
-WebViewTests/WebViewTest.DownloadCookieIsolation_CrossSession/SiteIsolationForGuestsEnabled

# These tests fail because we intentionally disable fenced frames via
# blink::features::kFencedFrames
# blink::features::kFencedFrames and
-AccessContextAuditFencedFrameBrowserTest.*
-All/HostedAppProcessModelFencedFrameTest.FencedFrameHasDifferentSiteInstance/0
-All/IntentPickerBubbleViewFencedFrameBrowserTest.*
-All/IntentPickerIconFencedFrameBrowserTest.ShouldShowIntentPickerInFencedFrame/*
-All/PaintPreviewFencedFrameBrowserTest.*
-All/PDFExtensionPrerenderAndFencedFrameTest.*
-All/SafeBrowsingFencedFrameBrowserTest.*
-All/SecurityStateTabHelperFencedFrameTest.*
-AmpPageLoadMetricsFencedFrameBrowserTest.AmpFencedFrame
-AppBannerManagerFencedFrameBrowserTest.FencedFrameShouldNotUpdateState
-AutoplayPolicyFencedFrameTest.AutoplayAllowedByPolicy
-AutoplayPolicyFencedFrameTest.AutoplayAllowlist_Allowed
-BackgroundFetchFencedFrameBrowserTest.*
-ChromeAppAPIFencedFrameTest.NoInfo
-ChromeRegisterProtocolHandlerBrowserTest.FencedFrame
-CommerceHintAgentFencedFrameTest.VisitCartInFencedFrame
-ComposeEnablingWithFencedFramesBrowserTest.DisabledInFencedFrames
-ContentScriptApiFencedFrameTest.InjectionMatchesCorrectExtension
-ContentSettingsWithFencedFrameBrowserTest.FencedFrameSetsCookie
-ContentSettingsWithFencedFrameBrowserTest.NestedFramesRendererContentSettings
-ContentSettingsWithFencedFrameBrowserTest.RendererContentSettings
-ContentSettingsWithFencedFrameBrowserTest.StorageAccessInFencedFrame
Expand All @@ -846,20 +861,75 @@
-ContextMenuFencedFrameTest.Save*
-ContextMenuFencedFrameTestNoTestingConfig.AutomaticBeaconSentAfterContextMenuNavigation
-DeclarativeNetRequestApiFencedFrameTest/DeclarativeNetRequestApiFencedFrameTest.*
-ExecuteScriptApiFencedFrameTest.Load
-ExtensionActionRunnerFencedFrameBrowserTest.DoNotResetExtensionActionRunner
-ExtensionActionRunnerFencedFrameBrowserTest.FencedFrameDoesNotClearActiveExtensions
-ExtensionWebRequestApiFencedFrameTest.DeclarativeSendMessage
-ExtensionWebRequestApiFencedFrameTest/ExtensionWebRequestApiFencedFrameTest.*
-ExtensionWebRequestApiFencedFrameTest.Load
-ExternalProtocolHandlerSandboxFencedFrameBrowserTest.*
-FencedFrameDownloadTest.DownloadRequestLimiterIsUnaffectedByFencedFrame
-FencedFrameDownloadTest.FencedFrameSandboxFlagBlockDownload
-FencedFrameDownloadTest.NetworkCutoffBlockSaveImageAs
-FencedFrameFileSystemAccessBrowserTest.RequestWriteAccess
-FencedFrameLoadingPredictorBrowserTest.*
-FencedFrameReduceAcceptLanguageBrowserTest.CrossOriginFencedFrame
-FencedFrameReduceAcceptLanguageBrowserTest.SameOriginFencedFrame
-FencedFrameSiteDetailsBrowserTest.*
-FencedFrameTaskBrowserTest.*
-FramebustBlockFencedFrameTest.FramebustBlocked_FencedFrameNavigation
-HistoryFencedFrameBrowserTest.FencedFrameDoesNotAffectLoadingState
-InsecureFormNavigationThrottleFencedFrameBrowserTest.DoNotCreateSecurityInterstitialInFencedFrame
-InspectUIFencedFrameTest.*
-LoginDetectionFencedFrameBrowserTest.FencedFrameShouldNotRecordLoginDetectionMetrics
-MediaEngagementContentsObserverFencedFrameBrowserTest.SendEngagementLevelToRenderFrameOnFencedFrame
-MessagingApiFencedFrameTest.Load
-MessagingApiFencedFrameTest/MessagingApiFencedFrameTest.*
-MixedContentSettingsTabHelperFencedFrameBrowserTest.IgnoreInsecureContentInFencedFrame
-NavigationPredictorFencedFrameBrowserTest.EnsureFencedFrameDoesNotCreateNavigationPredictor
-NetErrorTabHelperWithFencedFrameTest.CanRunDiagnosticsDialogOnFencedFrame
-NewTabPageNavigationThrottleFencedFrameTest.FencedFrameShouldNotAffectTitle
-NoStatePrefetchFencedFrameBrowserTest.ShouldNotRecordNavigation
-PageLoadMetricsBrowserTestWithFencedFrames.PageLoadPrivacySandboxAdsFencedFramesMetrics
-PageLoadMetricsObserverFencedFrameBrowserTest.FencedFrameCountsAsSubFramePageLoad
-PageTextObserverFencedFrameBrowserTest.DoNotDispatchResponseOnFencedFrame
-PerformanceHintsObserverFencedFrameTest.*
-PermissionRequestManagerWithFencedFrameTest.GetCurrentPosition
-PermissionRequestManagerWithFencedFrameTest.RequestPermissionThruDelegate
-PictureInPictureWindowControllerFencedFrameBrowserTest.FencedFrameShouldNotCloseWindow
-PlatformAppNavigationRedirectorFencedFrameBrowserTest.DoNotLaunchAppInFencedFrames
-PrefetchProxyFencedFrameBrowserTest.*
-PrintFencedFrameBrowserTest.DocumentExecCommand
-PrintFencedFrameBrowserTest.ScriptedPrint
-SBNavigationObserverBrowserTest.FencedFrameNavigationEventsAndReferrerChain
-SigninReauthViewControllerFencedFrameBrowserTest.*
-SSLFencedFrameBrowserTest.CertErrorInFencedFrame
-SSLFencedFrameBrowserTest.InAppTestProceededBadCertPageInFencedFrame
-SafeBrowsingTriggeredPopupBlockerFencedFrameBrowserTest.ShouldNotTriggerPopupBlocker
-SafeBrowsingTriggeredPopupBlockerFencedFrameBrowserTest.ShouldTriggerPopupBlocker
-SameOriginObserverFencedFrameTest.FFDoesNotAffectSameOriginState
-SecurityStatePageLoadMetricsFencedFrameBrowserTest.DoNotRecordOnCommitSecurityLevelHistogram
-SoundContentSettingObserverFencedFrameBrowserTest.AddAutoplayFlagsInFencedFrame
-SubresourceFilterFencedFrameBrowserTest.CollapseBlockedFencedFrame
-SubresourceFilterFencedFrameBrowserTest.FencedFrameLoadFiltering
-SubresourceFilterFencedFrameBrowserTest.LoadFilteringNestedInFencedFrame
-SubresourceFilterFencedFrameBrowserTest.NavigatesToURLWithWarning_NoMessageLogged
-SubresourceFilterFencedFrameBrowserTest.OutermostFrameActivation
-TabContentsTagFencedFrameTest.FencedFrameDoesNotUpdateTitle
-TabManagerFencedFrameTest.TabManagerWasDiscarded
-TabStatsTrackerSubFrameBrowserTest.VerifyBehaviorOnSubFrameNavigation
-TabUnderBlockerFencedFrameTest.RedirectAfterGesture_WithFF_IsNotBlocked
-TabUnderBlockerFencedFrameTest.SimpleTabUnder_WithFencedFrame_IsBlocked
-TrustedVaultEncryptionKeysTabHelperBrowserTest.ShouldBindClientEncryptionKeysApiInFencedFrame
-TrustedVaultEncryptionKeysTabHelperBrowserTest.ShouldBindSyncEncryptionKeysApiInFencedFrame
-WebAuthFlowFencedFrameTest.FencedFrameNavigationFailure
-WebAuthFlowFencedFrameTest.FencedFrameNavigationSuccess
-WebNavigationApiFencedFrameTest.Load
-WebNavigationApiFencedFrameTest/WebNavigationApiFencedFrameTest.*
-WebViewTests/WebViewFencedFrameTest.FencedFrameInGuestHasGuestSiteInstance/IsolateFencedFramesDisabled
-WebViewTests/WebViewFencedFrameTest.FencedFrameInGuestHasGuestSiteInstance/IsolateFencedFramesEnabled
-WebViewTests/WebViewFencedFrameTest.FencedFrameInGuestHasGuestSiteInstance/SiteIsolationForGuestsEnabled
-WebViewWithDefaultSiteInstanceTest.FencedFrame

# These tests fail because we skip amp pages with deamp
-AMPPageLoadMetricsObserverTest.*
Expand Down

0 comments on commit 62158c6

Please sign in to comment.