Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jetstream and motionmark in perf #25599

Merged
merged 14 commits into from
Sep 19, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 17, 2024

Resolves brave/brave-browser#40603

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m self-assigned this Sep 17, 2024
@atuchin-m atuchin-m marked this pull request as ready for review September 17, 2024 10:42
@atuchin-m atuchin-m requested review from a team as code owners September 17, 2024 10:42
@atuchin-m
Copy link
Collaborator Author

atuchin-m commented Sep 17, 2024

@atuchin-m atuchin-m force-pushed the support-jetstream-and-motionmark-in-perf branch from 0f228a9 to e9001fd Compare September 18, 2024 10:17

args = parser.parse_args()
if args.subparser_name == 'wpr-cleanup':
wpr_utils.cleanup_archive(args.file, True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe control the second argument with a command line parameter like --cleanup_service_hosts which will default to True?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an argument --preseve-service-hosts

@atuchin-m atuchin-m merged commit 666a658 into master Sep 19, 2024
18 of 19 checks passed
@atuchin-m atuchin-m deleted the support-jetstream-and-motionmark-in-perf branch September 19, 2024 04:30
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Perf infra] Support jetstream2 and rendering.desktop/motionmark_fixed_2_seconds for PGO
3 participants