Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Work around flaky create_dist_zips on macOS (#25576)" #25631

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

mherrmann
Copy link
Collaborator

Reverts #25576. It seems the problem was fixed by #25581.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A. Pure dev concern.

This reverts commit ab04e49.
It seems that the other recent "fix" commit did fix the issue.
@mherrmann mherrmann self-assigned this Sep 18, 2024
@mherrmann mherrmann enabled auto-merge (squash) September 18, 2024 13:59
@mherrmann mherrmann merged commit acf76d2 into master Sep 18, 2024
19 checks passed
@mherrmann mherrmann deleted the revert-25576 branch September 18, 2024 19:29
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants