Upgrade from Chromium 130 to Chromium 131. #25662

….0.6723.6.

This reverts commit 2960a79. These histograms have been been deprecated and removed. Chromium change: https://chromium.googlesource.com/chromium/src/+/80016c67a22927fc92e4862e434809f8f685e7b8 commit 80016c67a22927fc92e4862e434809f8f685e7b8 Author: Alvin Lam <[email protected]> Date: Tue Aug 20 20:41:16 2024 +0000 [TP Onboarding] Remove Eligibility API. OBSOLETE_HISTOGRAMS="Removing Histograms that track notice state as part of the onboarding notice deprecation" Bug: 359192834

This is mostly a token replacement, although the new type is scoped enum, which requires explicit casts. Chromium change: https://chromium.googlesource.com/chromium/src/+/e914ad79c884e7beb1ec28342546e4b8d8f23847 commit e914ad79c884e7beb1ec28342546e4b8d8f23847 Author: Md Hasibul Hasan <[email protected]> Date: Tue Aug 20 12:38:58 2024 +0000 [UI] Use mojo enum for `DialogButton` This CL removes `DialogButton` enum from ui_base_types.h. Replaces the uses of `DialogButton` with the mojo version. The following script is used for replacing with different folder name. Script: https://issues.chromium.org/issues/355460976#comment2 AX-Relnotes: N/A Bug: 355460976

This is of no consequence as none of our code was making use of this argument. Chromium change: https://chromium.googlesource.com/chromium/src/+/2a5ed806c79db0300ed081fab533aba37bb814b4 commit 2a5ed806c79db0300ed081fab533aba37bb814b4 Author: David Bienvenu <[email protected]> Date: Tue Aug 20 18:51:19 2024 +0000 Remove Launch.Modes histogram. Launch.Modes was deprecated in favor of Launch.Mode2 almost 2 years ago. This CL removes Launch.Modes and all the code that recorded it. OBSOLETE_HISTOGRAM[Launch.Modes]=Replaced by Launch.Mode2 OBSOLETE_HISTOGRAM[Windows.Launch.TaskbarInstallerPinned]=Expired Bug: 40239637

Chromium change: https://chromium.googlesource.com/chromium/src/+/39d79d684d4ff5a7dcb7f9050e5d0ebd07bcf131 commit 39d79d684d4ff5a7dcb7f9050e5d0ebd07bcf131 Author: Christine Ying <[email protected]> Date: Tue Aug 20 16:43:54 2024 +0000 [PrivacyPolicy] Link the Privacy Policy embedded page. Links the privacy policy embedded page to the PS dialog untrusted UI under the "privacy-policy" page Change-Id: I9542476c3da8b8f7c03888fa5f92e06a3acf397e Bug: 358087159

Browser state headers are now under `profile/`. Chromium change: https://chromium.googlesource.com/chromium/src/+/c116f5bfb3e61e40665a49145bdbf307d92db740 commit c116f5bfb3e61e40665a49145bdbf307d92db740 Author: Aliona DANGLA <[email protected]> Date: Mon Aug 19 12:09:02 2024 +0000 [iOS] Replace imports of chrome browser state manager Replace import that as been introduced during migration. Fixed: 359176329

This is merely a header inclusion replacement where `browser_state` becomes `profile/`. Chromium change: https://chromium.googlesource.com/chromium/src/+/288dc8c48b50000cd9d774d6c6aef5abb13cd15b commit 288dc8c48b50000cd9d774d6c6aef5abb13cd15b Author: Aliona DANGLA <[email protected]> Date: Tue Aug 20 15:20:55 2024 +0000 [iOS] Replace imports for sign in info and push notification This is part of renaming Chrome browser state project. Fixed: 360843134, 360843194

Chromium change: https://source.chromium.org/chromium/chromium/src/+/411baffb653d80aff9bd7496239432181c4e7977 commit 411baffb653d80aff9bd7496239432181c4e7977 Author: Erik Chen <[email protected]> Date: Tue Aug 20 07:14:06 2024 +0000 Stub out TabFeatures in tab unit tests. In production code, tabs are always created with TabFeatures. There are some unit tests that create tabs outside the regular context of a Browser/BrowserView. These tests need to stub out TabFeatures. This CL creates a utility method to do so, and calls it from relevant unit tests. Change-Id: I9bd3d71a3041e873541636e08ac2285cdf642263 Bug: 360169305

…der" This reverts commit d854658. Chromium change: https://chromium.googlesource.com/chromium/src/+/8b5230a906edca638bcdc16b9c84cf3af04fb3e2 commit 8b5230a906edca638bcdc16b9c84cf3af04fb3e2 Author: Shunya Shishido <[email protected]> Date: Wed Aug 21 01:44:28 2024 +0000 Revert "Remove Launch.Modes histogram." This reverts commit 2a5ed806c79db0300ed081fab533aba37bb814b4. Reason for revert: Tests started failing in Mac11, 12, 13 Tests. Original change's description: > Remove Launch.Modes histogram. > > Launch.Modes was deprecated in favor of Launch.Mode2 almost 2 years ago. > This CL removes Launch.Modes and all the code that recorded it. > > OBSOLETE_HISTOGRAM[Launch.Modes]=Replaced by Launch.Mode2 > > OBSOLETE_HISTOGRAM[Windows.Launch.TaskbarInstallerPinned]=Expired > > Bug: 40239637 > Change-Id: I118d9290a7c15814a0c9b3f04ccac1c30bb82586 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5794174 > Reviewed-by: Avi Drissman <[email protected]> > Commit-Queue: David Bienvenu <[email protected]> > Reviewed-by: Caitlin Fischer <[email protected]> > Code-Coverage: [email protected] <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1344299} Bug: 40239637, 361197694

This attribute has been allowed recently, and the macro `UNLIKELY` has been deleted. Chromium change: https://chromium.googlesource.com/chromium/src/+/2b074078243eb841259e6c61db81b48e10ad1ce4 commit 2b074078243eb841259e6c61db81b48e10ad1ce4 Author: Peter Kasting <[email protected]> Date: Thu Aug 22 00:01:17 2024 +0000 Remove [UN]LIKELY(). These have been replaced with the C++20 versions. Bug: 40256217

Upstream is plumbling WebContents discard through some of types that we override. This is immaterial to our code, however it has to be matched through our overrides to be plummed through them. This change adds the argument to the missing interfaces. Chromium change: https://chromium.googlesource.com/chromium/src/+/00d3927706c48be0896aac45e9341db2470c16bd commit 00d3927706c48be0896aac45e9341db2470c16bd Author: Thomas Lukaszewicz <[email protected]> Date: Wed Aug 21 23:54:10 2024 +0000 Reland "Implement WebContents discard by clearing the primary frame document" This is a reland of commit ce4ea2692091b299b26cc7967f9e1b980c583e09 See diff against PS1. Addressed timeout issue in DiscardClearsDedicatedWorkers test. Destruction of blink::DedicatedWorker post Discard() relies on async GC sweep in V8, which can result in timeouts on bots. Updated extension tab loading status to report unloaded when the tab is discarded. The tab will retain its render process when discarded with the new mechanism (consistent with previous behavior). Original change's description: > Implement WebContents discard by clearing the primary frame document > > See go/discard-frame-tree for additional details and to contribute > to discussion. > > This carries on from fdoray's prototype (crrev.com/c/4060064) and > erik's follow up (crrev.com/c/5454457). > > This CL introduces a new discard mechanism that avoids needing > to replace the tab's WebContents. > > Discard works by clearing the primary frame tree, done via replacing > Blink's primary document. This frees resources associated with the > primary frame and clears away any child frames attached to the > frame tree. > > Discard does not result in creation of any session entries and does > not emit navigation-related events > > Key changes: > - Update TabLifecycleUnit::FinishDiscard to no longer create > a empty WebContents for the discard operation. Instead discard > is implemented via replacing the primary blink document > > - The tab thumbnail implementation has been updated to handle the > new discard mechanism > > - OneTimePermissionsTrackerHelper was updated to leverage the > existing WebContents observation instead of relying on > TabLifecycleObserver > > - Multiple test updates / fixes to reflect discard API changes > and address incorrect assumptions (active tabs cannot be > discarded) > > Notifications for discard events with both the old and new > WebContents from the original API remain. These can be removed or > refactored in the follow up CLs. > > PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests && > out/Default/bin/run_perfetto_diff_tests` > > Bug: 347770670 > Change-Id: I32e87b2b992914a7ae0e0bbdddf78f1b27c5773b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637909 > Commit-Queue: Thomas Lukaszewicz <[email protected]> > Reviewed-by: Nicolás Peña <[email protected]> > Code-Coverage: [email protected] <[email protected]> > Reviewed-by: Victor Vianna <[email protected]> > Reviewed-by: Florian Jacky <[email protected]> > Reviewed-by: David Pennington <[email protected]> > Reviewed-by: Rakina Zata Amni <[email protected]> > Reviewed-by: Daniel Cheng <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1343920} Bug: 347770670

This event used to be part of the base class. Now with its deletion the internal function `SyncServiceImpl::StopAndClear` has to be exposed through `BraveSyncServiceImpl` to keep the existing code in use. This change turns the private function into a virtual function, to allow us to keep plugging our own changes into it. Chromium change: https://chromium.googlesource.com/chromium/src/+/769c49bea8b02913b69c1607bbe3d2190a3067bb commit 769c49bea8b02913b69c1607bbe3d2190a3067bb Author: Victor Hugo Vianna Silva <[email protected]> Date: Wed Aug 21 12:41:28 2024 +0000 Remove SyncService::StopAndClear() The method can be removed from the interface, its last usage was removed in crrev.com/c/5800572. Bug: 40797392

…rder" This reverts commit 2915585.

This new header is supposed to simplify the inclusion of `PlatformBrowserTest` for android/non-android tests. Chromium change: https://chromium.googlesource.com/chromium/src/+/dbf91b261f7a99ae7937eecc7ce2871feeb20c0b commit dbf91b261f7a99ae7937eecc7ce2871feeb20c0b Author: Devlin Cronin <[email protected]> Date: Thu Aug 22 22:35:56 2024 +0000 Move PlatformBrowserTest alias to platform_browser_test.h Currently, every test leveraging PlatformBrowserTest should include the following if-def block: ``` #if BUILDFLAG(IS_ANDROID) #include "chrome/test/base/android/android_browser_test.h" #else #include "chrome/test/base/in_process_browser_test.h" #endif ``` And, in turn, PlatformBrowserTest is an alias for either AndroidBrowserTest or InProcessBrowserTest, as defined in each of those files. This makes for a lot of boilerplate, and instead we can just move that if-def'd alias to a single file, platform_browser_test.h, that each class can include. This CL makes the following changes: - Updates any sites that previously included that if-def block to just include platform_browser_test.h - Fixes many IWYU cases where classes were not properly including any header file - `git cl format` (which fixes a few cases of improper header sorting) Bug: 361002665

This modernises code away from the unscoped enum that was being used. Chromium change: https://chromium.googlesource.com/chromium/src/+/78865bbb3da76c31548130e87e20ce1357ac3c8b commit 78865bbb3da76c31548130e87e20ce1357ac3c8b Author: Avi Drissman <[email protected]> Date: Thu Aug 22 20:57:19 2024 +0000 Don't use int for bindings Switch to a modern type, EnumSet. Fixed: 361106055

This file started pulling in some other headers, which eventually run into unwanted substitution for the toke `MIDI`.

This change affects a few overrides we have, however it is just a matter of passing the `WebContents` along. Chromium change: https://chromium.googlesource.com/chromium/src/+/3de66adf4d6bdb878c1a402401dc37353084a10f commit 3de66adf4d6bdb878c1a402401dc37353084a10f Author: Dibyajyoti Pal <[email protected]> Date: Fri Aug 23 23:34:03 2024 +0000 [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url This CL ensures that chrome::AddWebContents() always returns the web contents in which navigation has happened via ::Navigate() all the way to WebContentsImpl::CreateNewWindow(), during a new top level creation. This allows url loading in the web contents to be done via the same LoadUrlParams that the blink layer initially sent to complete navigation, leading to its properties still being maintained, which is more secure. Currently, the NavigationParams being created from this function do not maintain that information, which could be problematic. This helps solve the following PWA navigation capturing use-case: 1. App A creates a new top level traversable of App B for url b.com 2. App B already has an open window with a launch_handling of Navigate existing, in which case, App B's window is focussed. 3. Navigation to b.com/ happens in App B's window. Currently, the navigation to url b.com/ does not accurately populate all the LoadUrlParams, leading to dropped information. More details are in https://docs.google.com/document/d/1a8NgBD26ovh3rqpt5QWMAI6wQ-V68OJoEtJ-W--cNMY/edit#heading=h.ybqtwkw0flyr Bug: 359599878, 359600606, 351775835

This function has a switch over this enum, which causes build time failures for unhandled keys. Chromium change: https://chromium.googlesource.com/chromium/src/+/4b42ffd5892d47fafabcd8407dad2c5995e14fca commit 4b42ffd5892d47fafabcd8407dad2c5995e14fca Author: Sebastien Lalancette <[email protected]> Date: Fri Aug 23 13:10:25 2024 +0000 Add Error Histograms to Unexportable Windows Key Operations We noticed that TPM-backed keys fail to be created even if there exists a provider supporting creating those keys. Adding histograms to try and get insights into those failures (reported by users). Bug: 347025280

IsAllowlistedForContentSettings was deleted and, per our security folks, this check is no longer needed in our code. Chromium change: https://chromium.googlesource.com/chromium/src/+/0b2cf1f0a0a9de98d815a2f7be610fddcd071139 commit 0b2cf1f0a0a9de98d815a2f7be610fddcd071139 Author: Erik Chen <[email protected]> Date: Mon Aug 26 22:15:35 2024 +0000 Delete dead code for content settings. Bug: 40282541

Per the security and sync teams, we are good to leave this enabled now (it is associated with MVTs - most visited tiles - on iOS/Android devices). Chromium change: https://chromium.googlesource.com/chromium/src/+/0097fc4f2a54707d0a80a90a27d38768fb683a76 commit 0097fc4f2a54707d0a80a90a27d38768fb683a76 Author: Benjamin Williams <[email protected]> Date: Tue Aug 27 00:21:07 2024 +0000 [iOS] Remove flag kSyncSegmentsData The kSyncSegmentsData feature has been fully launched in M122, rendering the associated Finch experiment and feature flag code obsolete. This change removes this unnecessary code. Change-Id: If4c4cc300f219f66c9e0726bc94c26058359fd6e Fixed: 361123856

The world id argument used to have a default but now it has to be provided by the caller. Chromium change: https://chromium.googlesource.com/chromium/src/+/73cb98534375506288904ac3eb7ab6e35e94f0e0 commit 73cb98534375506288904ac3eb7ab6e35e94f0e0 Author: Avi Drissman <[email protected]> Date: Mon Aug 26 18:10:58 2024 +0000 Don't have default arguments on virtual functions in render_frame_host.h Bug: none

Extra keys have been added to `FormFactor` enum, and these need to be added to switch going over the device type. Chromium change: https://chromium.googlesource.com/chromium/src/+/d71df23934c6909345815b4264c26d656b89c6fa commit d71df23934c6909345815b4264c26d656b89c6fa Author: Rushan Suleymanov <[email protected]> Date: Mon Aug 26 08:17:19 2024 +0000 [Sync] Add DeviceInfo form factors to proto New form factors added: Automotive, Wearable, TV. These form factors are not used currently, so the default behavior similar to Unknown field is chosen in the existing switch-case code. Low-Coverage-Reason: TRIVIAL_CHANGE This CL adds new form factors and the file contains convertions between two similar enums. Bug: b:355283552

`BraveTestingProfile` is used as a substitution, and it therefore it must match the parent class constructor change. Chromium change: https://chromium.googlesource.com/chromium/src/+/bb1ae862cc7112b9615fc08ca43a885aecef00e7 commit bb1ae862cc7112b9615fc08ca43a885aecef00e7 Author: Hidehiko Abe <[email protected]> Date: Tue Aug 27 05:08:43 2024 +0000 Add CreateMode parameter to TestingProfile's ctor Also TestingProfile::Builder starts to support CreateMode. Bug: 341267441 Test: Tryjob

…arams Chromium change: https://source.chromium.org/chromium/chromium/src/+/65b9c4bd3383cf241a490f9e8988f14a8206c962 commit 65b9c4bd3383cf241a490f9e8988f14a8206c962 Author: Sohail Rajdev <[email protected]> Date: Wed Aug 21 10:20:10 2024 +0000 Allow WebContents with no window in ExtensionInstallPromptShowParams Earlier, ExtensionInstallPromptShowParams did not allow WebContents which had no parent window. They were only allowed in tests and this was ensured by the CHECK_IS_TEST() macro in the constructor. However, there can be real world cases (outside tests) in which the WebContents do not have a parent window. One example is WebstoreInstallWithPrompt that uses dummy WebContents which do not seem to have a parent window on macOS. This check relaxes the test-only assumption and allows non-test code to pass WebContents which do not have an associated parent window. Bug: 360321351

We map the new form factors to kUnknown as in the upstream code. Chromium change: https://source.chromium.org/chromium/chromium/src/+/d71df23934c6909345815b4264c26d656b89c6fa commit d71df23934c6909345815b4264c26d656b89c6fa Author: Rushan Suleymanov <[email protected]> Date: Mon Aug 26 08:17:19 2024 +0000 [Sync] Add DeviceInfo form factors to proto New form factors added: Automotive, Wearable, TV. These form factors are not used currently, so the default behavior similar to Unknown field is chosen in the existing switch-case code. Low-Coverage-Reason: TRIVIAL_CHANGE This CL adds new form factors and the file contains convertions between two sim> Bug: b:355283552

…trolsVisibilityDelegate - new argument at BottomControlsMediator.ctor - browserControlsVisibilityDelegate - new argment at BottomControlsCoordinator.ctor - browserControlsVisibilityDelegate Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d813d2e1ad66f8954e2e1da0821fa55eb9a21a70 Force browser controls to show up when creating new tab group When tab group is created via long press context menu, it'll triggers SimpleAnimationLayout then shows the tab group. This flow will detach the current tab and add it back; during this process, the new browser controls height, which is changed due to tab group UI being added, does not dispatched to the render. This causes a bug when the tab is reattached and becomes interactable, the offset read from TabBrowserControlsOffsetHelper is stale, leaving the tab group UI scene layer on the screen. This CL work around this by forcing the browser controls to be visible when the tab group UI becomes from hidden to visible. This has no impact to flows other than context menu -> "open new tab in group", as switching tabs will force browser controls to show transiently already. Bug: 357398783 Change-Id: I419b9303b033f0f621956952bc61c56a199fc338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809240

…ckListener - profile Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/4dcf25d9a523889df8026b58437ccc2ee49ba220 [IncognitoIndicator] Add IPH to tab switcher button for new menu options Screenshots: https://screenshot.googleplex.com/6y9hPhUnFbY6d36 With a11y (string pending confirmation from UX): https://screenshot.googleplex.com/762wcwG78ayVKnf Bug: 356925021 Change-Id: Ie6456048b6190dcc5022dbf9936d7f3a2ffac691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806464

… to chrome.browser Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/0190652b368204d112e1de7d9a6373a40e58b2a9 [Android] Modularize EphemeralTab Move EphemeralTab (a.k.a. PreviewTab) from chrome_java to chrome/browser/ui/android. For this: - The package path was changed from c/b/compositor.bottombar.ephemeraltab to c/b/ephemeraltab. Updated all the references accordingly. - moved ShareDelegateSupplier to chrome/browser/share/android. Bug: 355482871 Change-Id: I24cea3b4611863884b4befd819b0084cfce78dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5788897

R.id.toolbar_right_button => R.id.toolbar_new_tab_button Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/e142033b53e05476698d23c1428626fabb18c296 [Tab Group UI] Cleanup and better naming As we plan to redesign the bottom tab strip UI the naming of left/right is too generic and no longer sensible. This naming scheme also is incorrect for RTL layouts and is thus confusing. Rename everything to represent the purpose of the button rather than being generic. Also drive-by deletion of logic for changing the UI/usage of the show group dialog button (left button) that was never practically used. Bug: 362280397 Change-Id: I359f45023d8698e68c162dd2276c5766b527e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5813710

[Android] Rename AutofillProfile::Source to RecordType in Java code Related Chromium changes: https://source.chromium.org/chromium/chromium/src/+/481a48fe5621871e3ea8ec53905a900cd847c48e Rename AutofillProfile::Source to RecordType Home/Work account addresses are being introduced, making the Source name confusing. Furthermore, RecordType is consistent with what payment Autofill is using. See [1] for more details. This CL renames the enum and relevant AutofillProfile fields as well as related enums like AutofillProfileSourceCategory. It takes some shortcuts (since the CL is already huge) and doesn't rename any Java or TypeScript code. This will be done in a follow-up. https://chromium-review.googlesource.com/c/chromium/src/+/5783919/comment/34918a12_b18c6c44/ Low-Coverage-Reason: TRIVIAL_CHANGE Mass renaming Bug: 354706653 Change-Id: Ia45cd6d467360121b75c08a1fc301d6753802088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5811967 and https://source.chromium.org/chromium/chromium/src/+/68a2a8e5a99d199e500f784c0fd6bc303b1623a0 Rename AutofillProfile::Source in Java code Follow-up to crrev.com/c/5811967. Bug: 354706653 Change-Id: I18e5ebd44ffc04b85e12c484952f928d2b01d5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817283

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/de54cb9a2c9a0c5e5e28636493a51ac8db18305e Remove unused snackbar manager param. Change-Id: I95b80fc611d871fd3c9441a8f79776fce8cbcf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805249

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/7d2c054a846dc8b172a7cc1ded03d3e57a53456b Removed unused root view param. Change-Id: Id3c4f6b5da538658d313693ed781b0f884e3f638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804456

Chromium change: https://source.chromium.org/chromium/chromium/src/+/25f34a7ac88d09563b41c5686bb70d356b48f7c8 commit 25f34a7ac88d09563b41c5686bb70d356b48f7c8 Author: Yuan Yin <[email protected]> Date: Tue Aug 27 15:29:05 2024 +0000 [iOS] Support title for the navigation item when new navigation created by history.pushState() This problem occurs with iOS WKWebView because the interface provided by WKWebView is not perfect. Normally, The WKBackforwardList.title equals to the document.title when the page loads. But it's not always accurate. For WKWebView, The WKBackforwardList.title is empty when the new page is opened via history.pushState(). But the document.title (WKWebView.title) doesn't have to be empty or changed. So when opening a new page via history.pushState(), its title should be the current document.title. To solve this problem, When the WKBackforwardList.title is empty for current navigation, the document.title is read> Bug: 41438347

Need this to fix build with `args.use_login_database_as_backend = true` option Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/70fb340855605469deb626635cdfee00e3d8caf8 Add a feature flag for Phase 2 of OSCryptAsync implementation Bug: 345691490 Change-Id: I9e317615238d89fd92919a9c823d43c67e289e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5762611

…bled Now that upstream supports non-special scheme URLs, we needed to modify the way that we parse these. In the past, the URL's host piece would be empty for these URLs and the path would have the combined host + path. Now, the host piece contains the host and the path piece contains the path. Chromium change: https://source.chromium.org/chromium/chromium/src/+/28568c8eeedb68fed7215c665d1241b646803a0b commit 28568c8eeedb68fed7215c665d1241b646803a0b Author: Hayato Ito <[email protected]> Date: Mon Aug 26 23:49:05 2024 +0000 [Ship] Support non-special scheme URLs Support non-special scheme URLs, enabling the flag `StandardCompliantNonSpecialSchemeURLParsing`. See the Intent to Ship [^1] (which got 3 LGTMs) and the platform status [^2] for more details. Rebasing: While enabling the flag, this CL also rebased web test expectations. Despite the effort to minimize the size of this flag flip CL, this CL still include a significant number of rebaselines due to the nature of the update. Each rebase was already carefully reviewed individually (details in [^3]). - WPT URL tests have been tracked in virtual tests. This CL simply copies the virtual test result to the base. - Other non-WPT or non-URL WPT tests were reviewed individually. A tool, `blink_tool.py rebaseline-cl`, was used to automate the rebasing process. However, a few tests still failed [^4] due to the unexpected PNG files added by the tool. Thus, I removed the PNG files using the following: : git upstream-diff --name-only | grep 'png$' | xargs git restore -s origin/main All tests are now passing, and the change is ready to be shipped. - [^1] Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/svzicLXbKjw/m/aKt9fw7tBgAJ - [^2] Platform status: https://chromestatus.com/feature/5201116810182656 - [^3] https://docs.google.com/spreadsheets/d/1Pqw1iKXK_lxHj-kLIAeRFs-khFz-BPZDio1W7SgEVE4/edit?usp=sharing - [^4] https://chromium-review.googlesource.com/c/chromium/src/+/5802682?checksPatchset=2&tab=checks Bug: 40063064

This feature flag has been renamed and moved to another header, and this change corrects our overrides to keep disabling this flag. Chromium change: https://chromium.googlesource.com/chromium/src/+/9f0e9709a8d56053d381f44ed483d4e144469902 commit 9f0e9709a8d56053d381f44ed483d4e144469902 Author: Dibyajyoti Pal <[email protected]> Date: Wed Aug 28 16:24:15 2024 +0000 [PWA] Move link capturing flag to content/, rename to nav capturing This CL moves the link capturing flag and related parameters to be publicly accessible from the content/ layer. This allows the flag to be used to control the behavior of the web contents implementation introduced in crrev.com/c/5791853, and turned off if needed in case some emergency. Also renames the flag to be called PwaNavigationCapturing so that it makes some sense when referred to from WebView, as done in crrev.com/c/5809221. Renames mostly include the feature flag itself, its usages as well as the strings to be shown on chrome://flags. See context in https://chromium-review.googlesource.com/c/chromium/src/+/5791853/comment/825274d4_02b95051/ Bug: 362123239, 359599878, 351775835

This virtual used to pass around a `WebContents` instance. This change is of no consequence to the single case we override this function. Chromium change: https://chromium.googlesource.com/chromium/src/+/055f0213071a06b4f359b8ca2f9fd2da18dda017 commit 055f0213071a06b4f359b8ca2f9fd2da18dda017 Author: David Pennington <[email protected]> Date: Tue Aug 27 22:05:28 2024 +0000 [WC tsm removal] use tabs::TabModel from TabGroupedStateChanged update observer method to use tab update TabGroupStateChanged to use tab Change-Id: Id5c3496e8d5aede837c86b4a727d5049bddc694b Bug: 349161508

`ChromeRenderThreadObserver` doesn't have `is_incognito_process()` anymore, and the state should be returned from `chrome::IsIncognitoProcess()`. Chromium change: https://chromium.googlesource.com/chromium/src/+/22e259a86b120391897efb3034d2b7a508ff608b commit 22e259a86b120391897efb3034d2b7a508ff608b Author: Devlin Cronin <[email protected]> Date: Thu Aug 29 00:46:11 2024 +0000 Add a separate "process_state" file and target in //chrome/renderer Currently, whether a process is incognito is stored on the ChromeRenderThreadObserver. This is not ideal since, 1) It has nothing to do with observing the render thread, and 2) Anything that needs to check whether a process is incognito then needs to depend on ChromeRenderThreadObserver, which can make cyclical dependencies when trying to extract out pieces from the monolithic //chrome/renderer BUILD file. Fix this by pulling the tracking for is_incognito_process into a new file, process_state.h, which is in its own source set, //chrome/renderer:process_state. This CL should have no effective behavior change. Bug: None

Chromium change: https://chromium.googlesource.com/chromium/src/+/35fdfb051a266219ed0a79cea20047b36ff50262 commit 35fdfb051a266219ed0a79cea20047b36ff50262 Author: Andrew Grieve <[email protected]> Date: Thu Aug 29 19:44:13 2024 +0000 Android: Roll Dagger 2.30 -> 2.52 And switch to //third_party/android_build_tools/dagger_compiler for the annotation processor (removes it from android_deps) Bug: 362735859

This reverts commit 969dadf. Chromium change: https://chromium.googlesource.com/chromium/src/+/034b34f49000199034609f81cdf1397a3276b410 commit 034b34f49000199034609f81cdf1397a3276b410 Author: Thomas Lukaszewicz <[email protected]> Date: Thu Aug 29 22:44:32 2024 +0000 Revert "Reland "Implement WebContents discard by clearing the primary frame document"" This reverts commit 00d3927706c48be0896aac45e9341db2470c16bd. Reason for revert: Reland impl with finch flag Autoformatting changes Keeps BackForwardCacheDisable::DisabledReasonId::kDiscarded for reuse in reland. Original change's description: > Reland "Implement WebContents discard by clearing the primary frame document" > > This is a reland of commit ce4ea2692091b299b26cc7967f9e1b980c583e09 > > See diff against PS1. > > Addressed timeout issue in DiscardClearsDedicatedWorkers test. > Destruction of blink::DedicatedWorker post Discard() relies on > async GC sweep in V8, which can result in timeouts on bots. > > Updated extension tab loading status to report unloaded when the > tab is discarded. The tab will retain its render process when > discarded with the new mechanism (consistent with previous behavior). > > Original change's description: > > Implement WebContents discard by clearing the primary frame document > > > > See go/discard-frame-tree for additional details and to contribute > > to discussion. > > > > This carries on from fdoray's prototype (crrev.com/c/4060064) and > > erik's follow up (crrev.com/c/5454457). > > > > This CL introduces a new discard mechanism that avoids needing > > to replace the tab's WebContents. > > > > Discard works by clearing the primary frame tree, done via replacing > > Blink's primary document. This frees resources associated with the > > primary frame and clears away any child frames attached to the > > frame tree. > > > > Discard does not result in creation of any session entries and does > > not emit navigation-related events > > > > Key changes: > > - Update TabLifecycleUnit::FinishDiscard to no longer create > > a empty WebContents for the discard operation. Instead discard > > is implemented via replacing the primary blink document > > > > - The tab thumbnail implementation has been updated to handle the > > new discard mechanism > > > > - OneTimePermissionsTrackerHelper was updated to leverage the > > existing WebContents observation instead of relying on > > TabLifecycleObserver > > > > - Multiple test updates / fixes to reflect discard API changes > > and address incorrect assumptions (active tabs cannot be > > discarded) > > > > Notifications for discard events with both the old and new > > WebContents from the original API remain. These can be removed or > > refactored in the follow up CLs. > > > > PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests && > > out/Default/bin/run_perfetto_diff_tests` > > > > Bug: 347770670 > > Change-Id: I32e87b2b992914a7ae0e0bbdddf78f1b27c5773b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637909 > > Commit-Queue: Thomas Lukaszewicz <[email protected]> > > Reviewed-by: Nicolás Peña <[email protected]> > > Code-Coverage: [email protected] <[email protected]> > > Reviewed-by: Victor Vianna <[email protected]> > > Reviewed-by: Florian Jacky <[email protected]> > > Reviewed-by: David Pennington <[email protected]> > > Reviewed-by: Rakina Zata Amni <[email protected]> > > Reviewed-by: Daniel Cheng <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1343920} > > Bug: 347770670 > Change-Id: Idba13fec3c375c9f88727826386729963bef9166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799663 > Code-Coverage: [email protected] <[email protected]> > Reviewed-by: Victor Vianna <[email protected]> > Reviewed-by: Erik Chen <[email protected]> > Commit-Queue: Thomas Lukaszewicz <[email protected]> > Reviewed-by: Francois Pierre Doray <[email protected]> > Reviewed-by: Florian Jacky <[email protected]> > Reviewed-by: Nicolás Peña <[email protected]> > Reviewed-by: Daniel Cheng <[email protected]> > Reviewed-by: Rakina Zata Amni <[email protected]> > Reviewed-by: Emilia Paz <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1345153} Bug: 347770670

Fenced frames functionality is already disabled with its main flag. Chromium change: https://chromium.googlesource.com/chromium/src/+/57c74b90d4a6e506099c97022377d84f523b37cb commit 57c74b90d4a6e506099c97022377d84f523b37cb Author: Liam Brady <[email protected]> Date: Thu Aug 29 23:01:25 2024 +0000 Fenced frame: remove old feature flags from ~M120. This CL removes the following features: - FencedFramesM120FeaturesPart1 - FencedFramesM120FeaturesPart2 - FencedFramesCrossOriginAutomaticBeacons Now that these features have been fully launched for multiple releases, we can safely remove the code for the feature flags and their respective behavior. Bug: 360924257

This is complete deletion of the flags that were being disabled and the code it was guarding. Chromium change: https://chromium.googlesource.com/chromium/src/+/0171aada74cf7760fa7ec91448a2e49cbfc3f6c2 commit 0171aada74cf7760fa7ec91448a2e49cbfc3f6c2 Author: Roman Arora <[email protected]> Date: Thu Aug 29 17:37:29 2024 +0000 [ntp][history-clusters] Remove obsolete feature code OBSOLETE_HISTOGRAM[NewTabPage.Modules.LoadedWith.history_clusters]=Patterned histogram entry removed for obsolete NTP module. Bug: 334942479

This enforcement in upstream was causing build failures inside the bindings, where this now results in a build failure. This change aligns the type match to be a boolean. Chromium change: https://chromium.googlesource.com/chromium/src/+/ddff882fd0d582eb984415d6e8555342990f9820 commit ddff882fd0d582eb984415d6e8555342990f9820 Author: Nate Chapin <[email protected]> Date: Thu Aug 29 23:14:11 2024 +0000 Enforce promise resolve types match between the implementation and the IDL Also add a new extended attribute, [PromiseIDLTypeMismatch], for the few cases where matching the types isn't trivial.

The only use in our codebase for this function has been made redundant and can be removed. Chromium change: https://chromium.googlesource.com/chromium/src/+/7db7e84c48be10efc846ff1c713deb9cb1f4d8dc commit 7db7e84c48be10efc846ff1c713deb9cb1f4d8dc Author: weidongliu <[email protected]> Date: Mon Sep 2 01:53:37 2024 +0000 views: Set GetHeightForWidth to non-virtual. We have been able to replace the virtual requirement of GetHeightForWidth with CalculatePreferredSize(SizeBounds&). Now mark GetHeightForWidth as non-virtual to unify the calculation of the preferred size. Bug: 40232718

This is now part of the constructor, and the only call to this method is not necessary anymore. Chromium change: https://chromium.googlesource.com/chromium/src/+/cddebcc868072ca49794030e39a6935f4161aab7 commit cddebcc868072ca49794030e39a6935f4161aab7 Author: David Roger <[email protected]> Date: Fri Aug 30 16:44:40 2024 +0000 [Uno-D] Refactor PrimaryAccountManager initialization This CL has two changes: - remove the Initialize() method and inline it in the constructor. This function was unnecessary, and could cause bug if some caller forgets calling it. - change the AccessTokenFetcherTest to register the prefs before creating the PrimaryAccountManager. This was causing a crash with explicit signin, as the PrimaryAccountManager was accessing the kSigninAllowed preference before it was registered. Bug: b/317184865

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/669963ea86e76265f27de29b3925df97b4b8ea83 [Settings] Make the activity responsible for setting the title Today, each setting page implementation mutates the activity's title by calling getActivity().setTitle(). This is problematic as we redesign the setting UI for two primary reasons: (1) we are going to show the page title in the header of the detail pane, not as the activity title (2) we have to restore the page title when the user hits the back button after we migrate from the activity-based UI to the fragment-based UI. This patch rewrites all existing setting page implementation to tell the settings activity their page name, instead of directly mutating the activity title. For this purpose, this patch introduces a new interface SettingsPage to be implemented by all fragments that can be shown as a setting page. a few lines in the file Low-Coverage-Reason: TRIVIAL_CHANGE Interface change that modifies only Bug: b/356743945 Change-Id: I73a0db0b384850385cdce1ebb8077a96c761d7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804482

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/2d7def96d3ae7b798075e0014cdd79ae4619e4e9 [UPMAccessLossWarning] Move ApplicationLifecycle from chrome_java This CL moves ApplicationLifecycle.java into a separate new build target to make it more accessible from modularized code. Bug: 354876096 Change-Id: I863eebc83ef4d55c3e79c27716ce94cc3f723ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823481

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/f3868343ec40c11ce50f76484452c50cab326b01 [SurfacePolish][CleanUp] Clean up surface polish flag. This CL cleans up surface polish flag and any comments related to it. Bug: 331667743 Change-Id: I2c12ea24c4a1e0767fe54b43304f0a8518b16104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5824135

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/df3420a4ed4b5dc7b67830452d5616f43472edd0 Reland "Remove error-prone constructor: ScopedJavaGlobalWeakRef(env, jobject)" This reverts commit 12ca279a16cc568023bc07f53655aadef18179ec. Reason for reland: Still seeing leaks, so this wasn't the cause Original change's description: > Revert "Remove error-prone constructor: ScopedJavaGlobalWeakRef(env, jobject)" > > This reverts commit ded55b8eb2c9e5227e8983a1f44d67d6e707cd28. > > Reason for revert: possibly causing weak ref leaks. https://crbug.com/355975642 > > Original change's description: > > Remove error-prone constructor: ScopedJavaGlobalWeakRef(env, jobject) > > > > Updates all usages to use the const JavaRef<jobject>& constructor. > > > > Bug: 333398683 > > Change-Id: I9838272b76bf2dc353ba8b77f5240e841e60feea > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5648456 > > Commit-Queue: Andrew Grieve <[email protected]> > > Reviewed-by: Sam Maier <[email protected]> > > Owners-Override: Andrew Grieve <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1318729} > > Bug: 333398683, 355975642 > Change-Id: Ib1431247182850fdca101bd32821b738fcf680d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5767552 > Auto-Submit: Mohamed Heikal <[email protected]> > Owners-Override: Mohamed Heikal <[email protected]> > Commit-Queue: Mohamed Heikal <[email protected]> > Reviewed-by: Henrique Nakashima <[email protected]> > Commit-Queue: Henrique Nakashima <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1338128} Bug: 333398683, 355975642 Change-Id: I506680b021740faffea3e8dd4668781377a5fd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5825494

This affects the implementation for `SetAPIKeyForTesting`. Chromium change: https://chromium.googlesource.com/chromium/src/+/1f30fba88b01443407adaf2a6e1852b8beee8744 commit 1f30fba88b01443407adaf2a6e1852b8beee8744 Author: Mihai Sardarescu <[email protected]> Date: Mon Sep 2 20:27:30 2024 +0000 Split API key caches to load them separately. This CL splits the API caches into 4 different objects: the goal is to attempt to load them as lazily as possible, so that the main API key is loaded after the FeatureList is initialized on ChromeOS. This CL assumes that there one of the other keys stored in the old `g_api_key_cache` is used early during the initialization process on ChromeOS and this is why the entire cache of API Keys is loaded earlier than the feature flags are loaded. This CL is an attempt to load the main APIKey lazily (e.g. decouple its load from `metrics_key` which seems to be used early during the initialization sequence). To validate this approach, we expect there to be 0 entries in histogram Signin.APIKeyMatchesFeatureOnStartup for bucket "false" when the experiment is enabled.

This function has been removed and the `GetProfileManager` should be used in its place. This change does just that while also simplifying the chain call. Additionally, `GetLastUsedBrowserStateDeprecatedDoNotUse`, has been renamed to `GetLastUsedProfileDeprecatedDoNotUse`. Chromium change: https://chromium.googlesource.com/chromium/src/+/85f2d7bf8648b6b72e43ff332ae1cd7193c0c1f3 commit 85f2d7bf8648b6b72e43ff332ae1cd7193c0c1f3 Author: Sylvain Defresne <[email protected]> Date: Wed Aug 28 08:38:32 2024 +0000 [ios] Remove unused method GetChromeBrowserStateManager() All usage have been converted to GetProfileManager() so the old method can be safely removed. Bug: 358299872 https://chromium.googlesource.com/chromium/src/+/0c0350c61805a1d2fe596c293b0d800259dc0d20 commit 0c0350c61805a1d2fe596c293b0d800259dc0d20 Author: Sylvain Defresne <[email protected]> Date: Thu Aug 29 12:47:47 2024 +0000 [ios] Rename ProfileManagerIOS methods Rename the remaining methods of ProfileManagerIOS and change the implementation to use "profile" instead of "browser state" name. Bug: 359516222

prefs_section_autofill => prefs_section_autofill_brave to avoid conflict with the same name string from upstream Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/69c3668404e465bab43d5e1f15861465aff2c32d [Android][3PPWM] Add sections for privacy and autofill With one more generic autofill option, the structure of basic and advanced sections in settings isn't a great fit anymore. Therefore, reorder the settings into new sections according to the mock below. Mock: http://screen/6etAMsTFjmydV9p.png Screenshot: http://screen/7wnaomW8yupXZao.png Fixed: 361733921 Change-Id: I08a5bf310fb1fe673e65afe46fa358eabadc4565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809003

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/162b6c4692bc44d4dbdc42a753f091e57e1436a5 Collapse FilledButton & FilledButton.Flat styles Buttons should no longer have shadows per UX spec. Removing the raisedButton attribute, and consolidating the styles which allowed for "flag" vs "raised" buttons. Bug: 362360292 Change-Id: Ief15a8e8a5ecb4e0814845b75f11c028a9081d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5818057

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/6fdc96a642050852c3743e99349ca5cfdcbe96ee Revert "Add location string to ResourceRequest" This reverts commit 0fd2e596dfb9f5c46dfed1f373802cc921a66a74. Reason for revert: Since ResourceRequest is almost created via make_unique, `location` would be "/libc++/*/unique_ptr.h", which is not useful to detect the created location. Original change's description: > Add location string to ResourceRequest > > This CL adds a location string to ResourceRequest whereby > CorsURLLoaderFactory::IsValidRequest() warns with ResourceRequest > created location. > > Bug: 1456586 > Change-Id: Id09ba63391d539ee7f0555c1fb4dc1fe407818c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4653138 > Reviewed-by: Kenichi Ishibashi <[email protected]> > Commit-Queue: Yoichi Osato <[email protected]> > Reviewed-by: Dominick Ng <[email protected]> > Reviewed-by: Yoichi Osato <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1165172} Bug: 1456586 Change-Id: I35e806bd39c176940e1f23105c6fbaf3a6cc8e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5820233

The upstream header permission_controller_delegate.h was modified to include permission_controller.h, so we must also include that header in order to avoid accidentally overriding any of its methods. Chromium change: https://source.chromium.org/chromium/chromium/src/+/006519d9a150732225ac9b986c2a127d252aef21 commit 006519d9a150732225ac9b986c2a127d252aef21 Author: Yifan Luo <[email protected]> Date: Thu Aug 22 16:11:34 2024 +0000 Revert "[Android EMEA sheriff] Revert "[Permission] Remove SubscribeToPermissionStatusChange from PermissionManager"" This reverts commit ca0aec69ccdf5baaccac47ceafd7d68f18a967f6. Reason for revert: https://crrev.com/c/5772812 fixed the issue. Original change's description: > [Android EMEA sheriff] Revert "[Permission] Remove SubscribeToPermissionStatusChange from PermissionManager" > > This reverts commit c129a1b9aefc806182cc00c74fe296e5cc7945fc. > > Reason for revert: breaks `NFCHostTest.GetNFCTwice` content unittest on https://ci.chromium.org/ui/p/chrome/builders/ci/android-arm64> > > Original change's description: > > [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager > > > > This CL: > > * creates a separate file for Subscription enum > > * Removed duplicating `SubscribeToPermissionStatusChange` from PermissionManager > > * Move related unittests into new test file `chrome/browser/permissions/permission_subscription_unittest.cc` > > > > Bug: 40238954 > > Change-Id: Ic1e106880a0ee2b12384d151e95de9ded783c72b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498921 > > Reviewed-by: Rakina Zata Amni <[email protected]> > > Reviewed-by: Peter Beverloo <[email protected]> > > Reviewed-by: Sergey Ulanov <[email protected]> > > Commit-Queue: Yifan Luo <[email protected]> > > Reviewed-by: Sean Topping <[email protected]> > > Reviewed-by: Elias Klim <[email protected]> > > Reviewed-by: Andrey Kosyakov <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1325782} > > Bug: 40238954 > Change-Id: Ib1e0d21baa33075f5d0f93b127692824bd707378 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5690963 > Owners-Override: Igor Kraskevich <[email protected]> > Auto-Submit: Igor Kraskevich <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Igor Kraskevich <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1326078} Bug: 40238954

…mpl.h Optimized scalar_impl.h causes build failure on arm64 Release Android and Linux: ``` Instruction does not dominate all uses! %335 = shufflevector <2 x i32> %307, <2 x i32> poison, <2 x i32> zeroinitializer, !dbg !8388 %334 = and <2 x i32> %335, %285, !dbg !8388 LLVM ERROR: Broken module found, compilation aborted! PLEASE submit a bug report to https://crbug.com in the Tools>LLVM component, run tools/clang/scripts/process_crashreports.py (only if inside Google) to upload crash related files, and include the crash backtrace. Stack dump: 0. Running pass "verify" on module "obj/brave/third_party/bitcoin-core/libsecp256k1.a(secp256k1.o at 1962)" LLVM ERROR: Failed to rename temporary file thinlto-cache/Thin-9a4a52.tmp.o to thinlto-cache/llvmcache-272B29F12FA6241B9ED677E1E102ABD8EFA5BD21: No such file or directory ``` macOS arm64 has test failures around cryptographic functions. Related Chromium change (probably): chromium/chromium@db80d4c Roll clang+rust llvmorg-20-init-1009-g7088a5ed-10 : llvmorg-20-init-3… …847-g69c43468-1 / [skipping Rust] https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/7088a5ed..69c43468 Ran: ./tools/clang/scripts/upload_revision.py 69c43468d3f21df6232fda0530f03f18b0f40345 --skip-rust and tools/clang/scripts/sync_deps.py and third_party/abseil-cpp/generate_def_files.py and hacked third_party/rust/windows_targets/v0_52/BUILD.gn Bug: 357660350, 361477271, 360916952 Change-Id: Id668c36faeae52e6a576f277056684527b23b832 Tricium: skip Disable-Rts: True Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:lacros-arm64-generic-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:ios-catalyst,win-asan,android-official Cq-Include-Trybots: chromium/try:fuchsia-arm64-cast-receiver-rel Cq-Include-Trybots: chromium/try:mac-official,linux-official Cq-Include-Trybots: chromium/try:win-official,win32-official Cq-Include-Trybots: chromium/try:win-arm64-rel Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86 Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-rel Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-riscv64-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-riscv64-rel Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-rel Cq-Include-Trybots: chromium/try:android-cronet-riscv64-dbg Cq-Include-Trybots: chromium/try:android-cronet-riscv64-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5822292 Reviewed-by: Amy Huang <[email protected]> Reviewed-by: Alex Gough <[email protected]> Commit-Queue: Hans Wennborg <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348507}

This only affects a single place where `0` was being passed as default. Chromium change: https://chromium.googlesource.com/chromium/src/+/bd15364a662c095e05f2ded9fb7c578e46281fb0 commit bd15364a662c095e05f2ded9fb7c578e46281fb0 Author: Avi Drissman <[email protected]> Date: Tue Sep 3 18:58:05 2024 +0000 Use an opaque type for FrameTreeNode IDs, part 1 The type FrameTreeNodeId is in a new file because otherwise it would have to live in render_frame_host.h, which is very heavyweight, and it would greatly increase the compile costs of files that didn't have to include it before but have to include it now. Bug: 361344235

This is merely an update on the method signature to match the one upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/85b2c6354a7565278d0238561cc7dc69a5d1e033 commit 85b2c6354a7565278d0238561cc7dc69a5d1e033 Author: Erik Chen <[email protected]> Date: Tue Sep 3 19:44:18 2024 +0000 Reduce fragility in SidePanelCoordinator (part 2 / N) Prior to this CL, SidePanelCoordinator tracked a SidePanelEntry. As the lifetime of SidePanelEntry is unrelated to that of SidePanelCoordinator, this had two effects: * It made it impossible to distinguish between: not showing a side-panel entry, and showing a side-panel entry that was destroyed. * A proliferation of unnecessary conditionals, as the side-panel entry can only be destroyed in a small number of code paths. This CL modifies SidePanelCoordinator to also track a UniqueKey. Most logic is migrated over to track the UniqueKey. This CL fixes bug 360274920 in passing. This CL modifies UniqueKey to track the tab handle rather than just a tab_scoped bool. This allows SidePanelCoordinator to distinguish between the SidePanelEntries when switching between tabs with the same SidePanelEntry::Key. This CL fixes a race-condition that was not seen in production code. Production code will typically deregister a SidePanelEntry and destroy it. However, the API for SidePanelCoordinator does not enforce this. This means that if production code deregistered but did not destroy a SidePanelEntry, there was a period of time (prior to the side-panel animation finishing) where the SidePanelCoordinator was pointing to an unregistered SidePanelEntry. Bug: 360274920, 363743081

Our overriden entry `kRemoteListProvider` was being handled in `ProviderTypeToSiteSettingsSource` through a substitution, however this now runs into issues with a new occurrence for the token used as an anchor in `ProviderToDefaultSettingSourceString`. This change removes the substitution, and adds the use of macro keys to both switch cases. Chromium change: https://chromium.googlesource.com/chromium/src/+/4cc790e6a254af0de72886e2f87b7f0e1425ae03 commit 4cc790e6a254af0de72886e2f87b7f0e1425ae03 Author: Fiona Macintosh <[email protected]> Date: Tue Sep 3 23:15:14 2024 +0000 Apply supervised icons to Family Link-enforced settings Before: https://screenshot.googleplex.com/5ecD4CXT8fd3Ec2 After: https://screenshot.googleplex.com/9Da7ox4QWCKEq63 This bug is something kmg@ noticed while testing FL settings. After some digging, I discovered that we are currently mistakenly mapping SiteSettingSource in C++ to ContentSettingProvider in TS. Miraculously, some of these values are the same (e.g. 'policy') and therefore work. However 'supervised_user' is not one of those miraculously working values. I am also removing obsolete values that have no source in the C++ or have no handling in WebUI (these were mostly added in crrev/c/1838652, with no reason stated for doing so). Note that this does not fix b/360877241 Change-Id: I1e909434cfcc7581b487dfe1b898c08b4dc3e334

This class' methods are supposed to be accessed through the instance retrieved with `GetInstance`. Chromium change: https://chromium.googlesource.com/chromium/src/+/bcf73217bfaf1adb3b51ba42dbfc9c396e8dc1c7 commit bcf73217bfaf1adb3b51ba42dbfc9c396e8dc1c7 Author: Helmut Januschka <[email protected]> Date: Tue Sep 3 23:49:18 2024 +0000 Shift PowerMonitor to non static Bug: 346931324

…r_window on Android ``` > gn gen ..../brave-browser/src/out/android_Debug_arm ERROR at //chrome/browser/ui/browser_window/BUILD.gn:5:1: Assertion failed. assert(is_win || is_mac || is_linux || is_chromeos) ^----- See //brave/test/BUILD.gn:1065:7: which caused the file to be included. "//chrome/browser/ui/browser_window", ^----------------------------------- ```

Some of the functions in this class have dropped the use of an `int`, in favour of an opaque type for the id. This change corrects the overload mismatches on our codebase. Chromium change: https://chromium.googlesource.com/chromium/src/+/580a3da6e0ea94caa1f127e4455fbdbd05625065 commit 580a3da6e0ea94caa1f127e4455fbdbd05625065 Author: Avi Drissman <[email protected]> Date: Wed Sep 4 16:16:56 2024 +0000 Use an opaque type for FrameTreeNode IDs, part 2 content/browser/loader and content/browser/renderer_host. Bug: 361344235

`ProfileResetter::ResetSettings` is the only public method that can be used for resetting now. This seems to be inconsequential to our our use of this function. Chromium change: https://chromium.googlesource.com/chromium/src/+/86c771ce114e122c0876f140b92ee63a0721c6b2 commit 86c771ce114e122c0876f140b92ee63a0721c6b2 Author: Behnood Momenzadeh <[email protected]> Date: Wed Sep 4 17:18:00 2024 +0000 Add ResetSettings to ProfileResetter With the future addition of Sanitize, this new feature would need to take advantage of resetting settings. As the Sanitize feature could not sit inside the ResetSettingsHandler, this CL aims to bring in the initialization that was done inside the ResetSettingsHandler into ProfileResetter so the Sanitize feature can directly call ProfileResetter. BUG=b:357420360, b:317898420 TEST=unit_tests --gtest_filter="*ResetSettingsHandlerTest.*" unit_tests --gtest_filter="*ProfileResetterTest.*"

This data member is now calculated through `CalculateAccessibleName`. We have been overriding `SetMode` to be able to change the value of `accessible_name_`. However, with upstream introducing `CalculateAccessibleName`, the overriden has been moved to this method for overriding the accessible name. Chromium change: https://chromium.googlesource.com/chromium/src/+/3f2d3399e85ba835caafb3b2051abcf2e129e5e2 commit 3f2d3399e85ba835caafb3b2051abcf2e129e5e2 Author: Divyansh Mangal <[email protected]> Date: Wed Sep 4 17:46:59 2024 +0000 [views-ax] Migrate kName in chrome\browser\* This CL migrates the kName attribute in views to be updated whenever its value should change, rather than querying the value and computing it only when needed. This CL also contains new unit tests for checking that the accessible name is indeed correctly getting updated. This CL is part of the ViewsAX project: https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 Bug: 325137417

This factory is now called `PushNotificationProfileServiceFactory`. Chromium change: https://chromium.googlesource.com/chromium/src/+/7eea766b7b2c93df91620f53a6818c71ab8dbb8e commit 7eea766b7b2c93df91620f53a6818c71ab8dbb8e Author: Sylvain Defresne <[email protected]> Date: Tue Sep 3 14:27:44 2024 +0000 [ios] Convert factories to ProfileKeyedServiceFactoryIOS Convert PushNotificationProfileServiceFactory to ProfileKeyedServiceFactoryIOS as this reduce the boilerplate. Also rename the service and the factory from PushNotification{BrowserState => Profile}Service*. Fixed: 363218334, 361040570, 361041169

This change only affects the header inclusion. Chromium change: https://chromium.googlesource.com/chromium/src/+/91b41bec3117d99bbb1e27deb7c9b8b8a0bf2a5e commit 91b41bec3117d99bbb1e27deb7c9b8b8a0bf2a5e Author: Aliona DANGLA <[email protected]> Date: Wed Sep 4 09:57:53 2024 +0000 [iOS] Remove chrome_browser_state.h Migrated in this CL https://crrev.com/c/5822781. Removes last occurrences and clean BUILD files. Bug: 358267438 https://chromium.googlesource.com/chromium/src/+/aae915ae782dd94008b4eb20d50fe51d5d722271 commit aae915ae782dd94008b4eb20d50fe51d5d722271 Author: Aliona DANGLA <[email protected]> Date: Mon Sep 2 15:12:14 2024 +0000 [iOS] Move chrome_browser_state.{h, mm} files Fixed: 358060033

This provider has been added on upstream, and it is now required on our own list of providers to satisfy linking requirements. Chromium change: https://chromium.googlesource.com/chromium/src/+/bb45708af77cd77d4f88f93676e4d55615c2394f commit bb45708af77cd77d4f88f93676e4d55615c2394f Author: Ali Juma <[email protected]> Date: Tue Sep 3 19:41:49 2024 +0000 [iOS] Call provider API for memory experimentation This calls the memory experimentation provider API. This also adds a histograms.xml entry for a histogram added to ios_internal in crrev.com/i/7549887. This is part of a sequence of CLs: 1) https://crrev.com/c/5756193 2) https://crrev.com/i/7549887 3) https://crrev.com/c/5756911 (this CL) Change-Id: Ia959a4613312bcaeb5e04b81a768fe5a6fae8cd3 Bug: 359252988

…scalar_impl.h" This reverts commit 9667b03.

…rc/src/secp256k1 Old USE_FORCE_WIDEMUL_INT64 caused build failure on arm64 Release Android and Linux: ``` Instruction does not dominate all uses! %335 = shufflevector <2 x i32> %307, <2 x i32> poison, <2 x i32> zeroinitializer, !dbg !8388 %334 = and <2 x i32> %335, %285, !dbg !8388 LLVM ERROR: Broken module found, compilation aborted! PLEASE submit a bug report to https://crbug.com in the Tools>LLVM component, run tools/clang/scripts/process_crashreports.py (only if inside Google) to upload crash related files, and include the crash backtrace. Stack dump: 0. Running pass "verify" on module "obj/brave/third_party/bitcoin-core/libsecp256k1.a(secp256k1.o at 1962)" LLVM ERROR: Failed to rename temporary file thinlto-cache/Thin-9a4a52.tmp.o to thinlto-cache/llvmcache-272B29F12FA6241B9ED677E1E102ABD8EFA5BD21: No such file or directory ``` macOS arm64 had test failures around cryptographic functions. Related Chromium change (probably): chromium/chromium@db80d4c Roll clang+rust llvmorg-20-init-1009-g7088a5ed-10 : llvmorg-20-init-3… …847-g69c43468-1 / [skipping Rust] https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/7088a5ed..69c43468 Ran: ./tools/clang/scripts/upload_revision.py 69c43468d3f21df6232fda0530f03f18b0f40345 --skip-rust and tools/clang/scripts/sync_deps.py and third_party/abseil-cpp/generate_def_files.py and hacked third_party/rust/windows_targets/v0_52/BUILD.gn Bug: 357660350, 361477271, 360916952 Change-Id: Id668c36faeae52e6a576f277056684527b23b832 Tricium: skip Disable-Rts: True Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:lacros-arm64-generic-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:ios-catalyst,win-asan,android-official Cq-Include-Trybots: chromium/try:fuchsia-arm64-cast-receiver-rel Cq-Include-Trybots: chromium/try:mac-official,linux-official Cq-Include-Trybots: chromium/try:win-official,win32-official Cq-Include-Trybots: chromium/try:win-arm64-rel Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86 Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-arm64-rel Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-riscv64-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-riscv64-rel Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-dbg Cq-Include-Trybots: chromium/try:android-cronet-mainline-clang-x86-rel Cq-Include-Trybots: chromium/try:android-cronet-riscv64-dbg Cq-Include-Trybots: chromium/try:android-cronet-riscv64-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5822292 Reviewed-by: Amy Huang <[email protected]> Reviewed-by: Alex Gough <[email protected]> Commit-Queue: Hans Wennborg <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348507}

Chromium change: https://source.chromium.org/chromium/chromium/src/+/d0f3f90735f9c7a2d96efca8c53d63e004c6e6eb commit d0f3f90735f9c7a2d96efca8c53d63e004c6e6eb Author: Jack Yammine <[email protected]> Date: Wed Sep 4 16:10:28 2024 +0000 [waffle]Cleanup SearchEngineChoiceTrigger feature flag The SearchEngineChoiceTrigger feature flag is now enabled by default. We clean up the related code while keeping the kSearchEngineChoiceTrigger feature flag because it is needed for the kSearchEngineChoiceTriggerRepromptParams feature param. This change focuses on Desktop platforms and modifies easy to fix iOS and android files. We don't touch the code in `IsChoiceScreenFlagEnabled` and related calls as they will be handled in b/318824817. We don't modify test code related to the DSE sync behavior. It will be handled in b/341011768. Bug: b:342387270

classExists and checkSuperName were failing for DeveloperSettings. Crash message said: Can't create handler inside thread Thread[Instr: org.chromium.base.test.BaseChromiumAndroidJUnitRunner,5,main] that has not called Looper.prepare() Related Chromium change: unclear

Chromium change: https://chromium.googlesource.com/chromium/src/+/45ddc32490f88c65c231dec85129696315906a3b commit 45ddc32490f88c65c231dec85129696315906a3b Author: rbpotter <[email protected]> Date: Fri Sep 6 23:37:42 2024 +0000 Downloads Manager: Migrate to Lit Bug: 40943652

… flag is not enabled" This reverts commit c0ea008. Chromium change: https://chromium.googlesource.com/chromium/src/+/17b1d05d2ccda19c3ebd903075227bc8e851acf0 commit 17b1d05d2ccda19c3ebd903075227bc8e851acf0 Author: Jack Yammine <[email protected]> Date: Mon Sep 9 09:14:00 2024 +0000 [waffle]Remove search_engines::IsChoiceScreenFlagEnabled() Remove the function and related calls and params. This is because the kSearchEngineChoiceTrigger feature is now fully launched. Fixed: b:364815974

Upstream is removing pointer/length pairs ctor for `RefCountedBytes`, and this change makes sure the uses of it in our codebase uses the spanified ctor. Chromium change: https://chromium.googlesource.com/chromium/src/+/0864e61788db17c2a4c3ed5dfd2c288956a2b03e commit 0864e61788db17c2a4c3ed5dfd2c288956a2b03e Author: Tom Sepez <[email protected]> Date: Thu Sep 5 20:14:36 2024 +0000 Remove unsafe forms of RefCountedBytes / RefCountedStaticMemory ctors Previous CLs have removed callers; this CL removes the code itself. Bug: 40284755

This flag has been removed, however it doesn't seem to be of much importance for our use case. Chromium change: https://chromium.googlesource.com/chromium/src/+/7918233811117f3bcdd0bc2aa69c6876a6304b69 commit 7918233811117f3bcdd0bc2aa69c6876a6304b69 Author: Florian Leimgruber <[email protected]> Date: Mon Sep 9 09:06:01 2024 +0000 Redefine inactive HeuristicSources for shadow prediction computation Recall that: - PatternSource identifies a JSON file. - HeuristicSource describes a mechanism to compute heuristic predictions. - Active HeuristicSource refers to the HeuristicSource whose predictions are used for user facing Autofill behavior. - Besides the active HeuristicSource, predictions might additionally be computed as an inactive HeuristicSource for shadow prediction metrics. Due to crrev.com/c/5836961, new patterns can be now added behind feature flags in the default JSON file. As a result, the experimental file is no longer necessary. This CL removes it from the build* and as a result, removes PatternSource::kExperimental. For shadow predictions, Heuristic::kExperimental is kept, so different predictions can be stored in AutofillField [1]. The behavior implemented by this CL is: - If no regex feature flags are enabled, HeuristicSource::kDefault is active and the only set of computed heuristic predictions. - If at least one regex feature flag is enabled, HeuristicSource::kExperimental is active. It corresponds to the predictions with all active regex feature flags applied. HeuristicSource::kDefault is computed as an inactive source. Shadow prediction metrics between kExperimental and kDefault are emitted. This is different from the current behavior, where inactivev predictions against kExperimental are always computed and metrics are emitted unconditionally. Due to HeuristicSource::kMachineLearning, which can be active or inactive too, it's slightly more complicated than the above: - When ML is disabled, the behavior is as described above. - When ML is enabled: - If ML is the active source (configured by a feature flag), only kDefault predictions (= no regex feature flags) are computed as an inactive source. Shadow prediction metrics between ML and kDefault are emitted. Regex feature flags don't apply at all in this configuration, even if some are active. This matches the current behavior where the any kAutofillParsingPatternActiveSource overrides are ignored when ML is active. Essentially, if there are two simultaneous rollouts, they will interfere. - If ML is an inactive source (again controlled by a feature flag), either kExperimental or kDefault is the active source - depending on whether regex feature flags are active. Everything behaves like in the ML disabled case, except that shadow prediction metrics between ML and kDefault are emitted too. The key changes from this CL are in: - GetActiveHeuristicSource() (in heuristic_source.cc) - FormStructure::DetermineNonActiveHeuristicTypes() GetNonActiveHeuristicSources() is removed. It was only called from there and the logic is actually significantly simpler than computing the set explicitly. - Since only a single PatternSource exist, the optimization from crrev.com/c/5200177 becomes unnecessary and is removed. A lot of the rest are trivial changes that result from removing PatternSource::kExperimental. Finally, this CL removes all non-test references of: - kAutofillDisableShadowHeuristics. Removed completely. - kAutofillParsingPatternProvider. Will be removed in a follow-up, because there are many references in tests. * A follow-up CL will delete it from the internal repository. [1] https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/autofill_field.h;l=366-367;drc=af1ff1695863c9c3ae591d77017c98bd51f9ecdf Bug: 364593932

This is merely an inclusion path correction. Chromium change: https://chromium.googlesource.com/chromium/src/+/359886ccf2092449ff291788a67ffcde3cc2b8ee commit 359886ccf2092449ff291788a67ffcde3cc2b8ee Author: Youngsoo Choi <[email protected]> Date: Fri Sep 6 03:57:59 2024 +0000 [PM] Move PageResourceMonitor metric to components/. This CL moves the PageResourceMonitor metric to //components, since the class doesn't have any dependencies on //chrome. Bug: 40623222

`OnBatteryPowerStatusChange` should be used in its place, and this change corrects our override for it. Chromium change: https://chromium.googlesource.com/chromium/src/+/7030aa51719360e6261a0eaa576c5df20cc16b08 commit 7030aa51719360e6261a0eaa576c5df20cc16b08 Author: elabadysayed <[email protected]> Date: Mon Sep 9 11:13:27 2024 +0000 [3/N] Remove old OnPowerChange in PowerObserver This CL is part of a series of a CLs to expose the tristate enum to all consumers, for more context please see https://docs.google.com/document/d/1znskYZJyfhbGmyu7OQC4-A58zdrl9_xyZT7E-jTbyXE/. This CL removes the old OnPowerChange from PowerObserver and uses OnBatteryPowerStatusChange instead which passes an enum value instead of boolean. Bug: b/339859756

An unwanted substitution has appeared on this file, in some very long inclusion chain. This change preempts the header inclusion pulling the offending file.

This target has been merged into an already included target. Chromium change: https://chromium.googlesource.com/chromium/src/+/d0641f57cc44a2a29655e0c6a79115a5ec9d9cdd commit d0641f57cc44a2a29655e0c6a79115a5ec9d9cdd Author: Aliona DANGLA <[email protected]> Date: Thu Sep 5 18:29:08 2024 +0000 [iOS] Rename {c_b_s => profile_ios}_impl and remove target Fixed: 358066580 Bug: 359148322

Chromium change: https://source.chromium.org/chromium/chromium/src/+/0e66fe55735df2b2c093f4d27021f73dee5411c5 commit 0e66fe55735df2b2c093f4d27021f73dee5411c5 Author: ginnnnnnny <[email protected]> Date: Thu Sep 5 18:42:24 2024 +0000 [iOS] Create provider API for additional features This provider API allows implementers to create additional features for components/frameworks unable to call BASE_DECLARE_FEATURE at compile time. Works in conjunction with crrev.com/i/7580765 and cl/663047355. Bug: 355550974

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/2e4ea7c9f2c0694a8776999d364ff61c277a90cd [Signin][Android] Clean up SeedAccountsRevamp experiment Bug: 365057341 Change-Id: Iab98aeb9cf48171953bab8bd5cd3260d74932229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5816770

…ethod anymore To check the websites urls now SafeBrowsingApiHandler must be used. This commit disables BraveSafeBrowsingApiHandler class, which in fact implements SafetyNetApiHandler. Related Chromium changes: https://source.chromium.org/chromium/chromium/src/+/e5700c49b75254cc1201a3bbea59b20b06328a27 Remove remaining functions in the interface. Internal reference was removed in https://crrev.com/i/7648757 OBSOLETE_HISTOGRAMS=No longer logged because URLs are checked through the new GMSCore Safe Browsing API. Bug: 40935425 Change-Id: I3ab1e5783395c63586bd4c5163541161027004bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837639 https://source.chromium.org/chromium/chromium/src/+/4d1a9d3d10a3d6e1697270afc723687b6eb94810 Remove unused functions after migrating URL checks to new GmsCore API. After the feature flag was removed in https://crrev.com/c/5805204, some functions, enums and histograms are no longer used. Some functions in the SafetyNetApiHandler interface are kept in this CL because they are still used in the internal repo. They will be removed in a follow-up CL. OBSOLETE_HISTOGRAMS=No longer logged because URLs are checked through the new GMSCore Safe Browsing API. Bug: 40935425 Change-Id: I03cbc731ee14084f1af8ffe30670e50ea8175391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838697 https://source.chromium.org/chromium/chromium/src/+/42a1ef002790b1e5a7345c24ba3673224499d4f3 Remove SafeBrowsingNewGmsApiForBrowseUrlDatabaseCheck feature flag This flag is set to enable by default since M129. Internal usage of this flag was removed in https://crrev.com/i/7608690. Bug: 40935425 Change-Id: I83111aeefb92d52e5fdc938678764500e14992ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805204

@TudorMagirescu

This fixes Lint error ``` ../../brave/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkManagerMediator.java:156: Warning: Using name is unsafe as it is a filename obtained directly from a ContentProvider. You should sanitize it before using it for creating a File. [UnsanitizedFilenameFromContentProvider] File file = new File(mContext.getFilesDir(), name); ~~~~ ``` Related Chromium change (android-security-lints): https://github.com/google/android-security-lints/pull/8/files Upload @TudorMagirescu's UnsanitizedFilenameFromContentProvider lint check

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/fddc9eedcefc391762751e387f9b292be94f8836 Move temporary OTR cookie file to the original profile dir. Previous location: <chrome_install_dir>/files/COOKIES.DAT New location: <chrome_install_dir>/app_chrome/[Profile Directory -- e.g. Default]/OTRTempState/COOKIES.DAT Bug: 40254448 Change-Id: I33f33bb26dd7751978ae0d6e6a51fedbc6b700e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838406

… no shouldShowUpdatedSettings arg https://source.chromium.org/chromium/chromium/src/+/17b1d05d2ccda19c3ebd903075227bc8e851acf0 [waffle]Remove search_engines::IsChoiceScreenFlagEnabled() Remove the function and related calls and params. This is because the kSearchEngineChoiceTrigger feature is now fully launched. Fixed: b:364815974 Change-Id: I1b3c253c656c76246fae96486b2863632878f17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837290

Chromium change: https://source.chromium.org/chromium/chromium/src/+/cb42228bc68db95266c6171453ec1cdc5a4ceb2a commit cb42228bc68db95266c6171453ec1cdc5a4ceb2a Author: Jack Yammine <[email protected]> Date: Tue Aug 20 13:04:09 2024 +0000 [waffle]Remove the kSearchEnginesSortingCleanup feature flag (2/2) Remove the feature flag as we want the feature to be enabled by default. Do the necessary cleanups to remove the now unused milestone that's saved in the keyword DB. Fixed: b:340412113

Chromium change: https://source.chromium.org/chromium/chromium/src/+/c211d4a21cc55525d1c15cd6e9d56f31310436d8 commit c211d4a21cc55525d1c15cd6e9d56f31310436d8 Author: dpapad <[email protected]> Date: Thu Sep 5 14:22:11 2024 +0000 WebUI: Bulk migrate iron-icon to cr-icon, part 4. In this part updating c/b/r/settings. Excluding a couple cases where <iron-icon src=...> is used, which is not currently supported by cr-icon. Fixing newly discovered bug (due to the stricter runtime checks of cr-icon), where a non-existent icon was used in privacy_page/secure_dns.html. This is in preparation of removing iron-icon from Desktop builds. Bug: 40943652

``` -o obj/brave/components/brave_rewards/browser/browser/rewards_service_impl.o In file included from ../../brave/components/brave_rewards/browser/rewards_service_impl.cc:6: In file included from ../../brave/components/brave_rewards/browser/rewards_service_impl.h:34: In file included from ../../brave/components/brave_wallet/browser/brave_wallet_service.h:25: In file included from ../../brave/components/brave_wallet/browser/zcash/zcash_wallet_service.h:20: ../../brave/components/brave_wallet/browser/zcash/zcash_rpc.h:19:10: fatal error: 'brave/components/services/brave_wallet/public/mojom/zcash_decoder.mojom.h' file not found 19 | #include "brave/components/services/brave_wallet/public/mojom/zcash_decoder.mojom.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ```

…t failed with Message: Can't connect to X11 window server using ':3' as the value of the DISPLAY variable.

These patches had their target path updated. These files used to be under `third_party/`. Chromium change: https://chromium.googlesource.com/devtools/devtools-frontend/+/e20bdacd076c94ada0411697d8c2c36c8af86dc6 commit e20bdacd076c94ada0411697d8c2c36c8af86dc6 Author: Simon Zünd <[email protected]> Date: Tue Aug 27 09:35:53 2024 +0200 [deps] Move ts_library out of third_party ts_library.py and typescript.gni do not contain any third party code. They had the Chromium license headers from the beginning. The only "third-party"ness they have, is that they use the "typescript" npm package. [email protected] Fixed: 362397305

… on CI it failed with" This reverts commit f15a582.

Chromium change: ChromeDevTools/devtools-frontend@e20bdac commit e20bdacd076c94ada0411697d8c2c36c8af86dc6 Author: Simon Zünd <[email protected]> Date: Tue Aug 27 09:35:53 2024 +0200 [deps] Move ts_library out of third_party ts_library.py and typescript.gni do not contain any third party code. They had the Chromium license headers from the beginning. The only "third-party"ness they have, is that they use the "typescript" npm package. [email protected] Fixed: 36239730

Chromium change: ChromeDevTools/devtools-frontend@b7d8504 commit b7d85047a37533a9edce584f957f5c993066dac6 Author: Benedikt Meurer <[email protected]> Date: Fri Aug 23 15:38:32 2024 +0200 [eslint] Migrate front_end/core/ to CONSTANT_CASE enum values. Note that this only migrates the code, but doesn't yet change the ESLint configuration, since other folders are still pending. Bug: 361720369

…use on lint crashed on CI with Message: Can't connect to X11 window server using ':3' as the value of the DISPLAY variable.

…ata because on lint crashed on CI with" This reverts commit 04530ba.

``` ../../brave/chromium_src/chrome/browser/download/android/download_utils.cc:7:10: fatal error: 'brave/browser/download/android/jni_headers/BraveMimeUtils_jni.h' file not found 7 | #include "brave/browser/download/android/jni_headers/BraveMimeUtils_jni.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```

Upstream code chains calls to GetBrowserWindowInterface() in several places now, preventing the use of TestTabStripModelDelegate as-is in our SplitView unit tests. Due to ongoing upstream changes in BrowserWindowInterface, that class also is not safely mockable as currently written. Instead, we've converted the SplitView unit tests to browser tests so there is no longer a need to mock those interfaces, which were only used very sparingly upstream to begin with.

Upstream seems to have completed the whole migration to an opaque `FrameTreeNodeId`. This change converts all the places that were using an `int` still. Chromium change: https://chromium.googlesource.com/chromium/src/+/e4de125f43660ff1f41e36fbff545c3bf2a7e401 commit e4de125f43660ff1f41e36fbff545c3bf2a7e401 Author: Avi Drissman <[email protected]> Date: Thu Sep 5 00:15:45 2024 +0000 Use an opaque type for FrameTreeNode IDs, part 15 content/public Bug: 361344235

`WebUIBubbleManager::MaybeInitPersistentRenderer` was being stubbed in brave, but this function is not more, so we can do away with the stub. Chromium change: https://chromium.googlesource.com/chromium/src/+/28ebfbc03cb7d7036868510f4dddb564e694a367 commit 28ebfbc03cb7d7036868510f4dddb564e694a367 Author: Thomas Lukaszewicz <[email protected]> Date: Wed Sep 11 00:54:41 2024 +0000 [tab search] Remove kWebUIBubblePerProfilePersistence kWebUIBubblePerProfilePersistence is a feature that allows sharing a single Tab Search instance across many different bubble hosts for a given profile. This feature experiment has concluded and the team is no longer pursuing this approach. This CL cleans up any feature-associated code. Bug: None

This function was taking a `SidePanelEntry` instance, but now both variants only take a `SidePanelEntry::Key`. Chromium change: https://chromium.googlesource.com/chromium/src/+/f96901b4389d051c9c1d520f82a60ae92a34add2 commit f96901b4389d051c9c1d520f82a60ae92a34add2 Author: Erik Chen <[email protected]> Date: Tue Sep 10 23:00:49 2024 +0000 Reduce fragility in SidePanelCoordinator (part 4 / N) This CL is primarily a refactor with no intended behavior change. It removes redundant logic from SidePanelCoordinator. This CL fixes a minor bug from part 2 where we were not correctly checking whether a closing extension was using the tab-scoped or window-scoped registry. This is not expected to have any user-visible effect, but is good to fix anyways. Bug: 363743081

This is a result of upstream spanification. For our case it seems to be very simple replacement. Chromium change: https://chromium.googlesource.com/chromium/src/+/c5f3a25855b895bb587af5dbd8ff3ebfb7be76e1 commit c5f3a25855b895bb587af5dbd8ff3ebfb7be76e1 Author: Fredrik Söderquist <[email protected]> Date: Tue Sep 10 19:26:09 2024 +0000 spanification: InspectorNetworkAgent and related bits Pass SpanOrSize<> to DidReceiveData() and a span<> to DidSendWebSocketMessage(). Propagate up and down the relevant call chains as needed. Use span<>s in NetworkResourcesData. Bug: 351564777

This only affects how certain instatiations were being done, as the data itself was only getting passed along. Chromium change: https://chromium.googlesource.com/chromium/src/+/eecda5d4d6f20fe6baba7f7c0eb0e02284a349f6 commit eecda5d4d6f20fe6baba7f7c0eb0e02284a349f6 Author: Joshua Pawlicki <[email protected]> Date: Wed Sep 11 13:48:38 2024 +0000 update_client: Simplify ping_manager. Also remove a dependency from util on component. Also improve memory safety in request_sender. Bug: 353249967

`ScriptValue` can be constructed from `V8Promise` with an isolate. Chromium change: https://chromium.googlesource.com/chromium/src/+/60d8423bb34a146cfb1a2d1ed8a818176ae410e9 commit 60d8423bb34a146cfb1a2d1ed8a818176ae410e9 Author: Andrey Kosyakov <[email protected]> Date: Wed Sep 11 18:03:42 2024 +0000 Remove ScriptPromise::AsScriptValue(), let call sites create it themselves Change-Id: I606a7b388bf90a1a283b474b242a14866d2f92c6

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/333ffb2d4a93d2ce9e9a5fabdf1e593d6d062e9d Remove and clean up old Translate Infobar code. Leaving translate_infobar_delegate because there are still iOS dependencies attached. Fixed: 353735844 Bug: 40213244 Change-Id: Ief6abe1485ef372f1ac44426b1edeb3b69b89208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5727132

"RetainOmniboxOnFocus" feature is used instead Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/46147680fe334aeec900ec6d76c8b9e443d07452 Adds flag-guarded support for retaining omnibox on focus. This CL adds flag-guarded support for retaining omnibox contents on focus (as opposed to clearing it). When enabled, omnibox contents will also be fully selected (to allow for quick replace) and zero-prefixed suggestions are still shown (to allow for quick search). When enabled, only devices with large screens, attached keyboards, and attached precision pointers are affected. Design doc: http://shortn/_g7JfqshAX0 Before: * google.com: http://shortn/_QQDvhI44dH * NTP w/o paste: http://shortn/_RowwKkjjGM * NTP w/ paste: http://shortn/_9Im63Fv4Ep After: * google.com: http://shortn/_29TqnQpVQE * NTP w/o paste: http://shortn/_whJqKzcDnv * NTP w/ paste: http://shortn/_ZnBOkVUvrU Bug: 347632178 Change-Id: I8c8ceffa766ff7c960f122241ae3fb2efe3654c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804846

This crate is used in brave, and it has now been introduced in upstream chromium as well. This change deletes the local copy for this crate, as this was causing duplicated id errors for the two crates, and makes sure we use the crate checked out on upstream. However, some feature patching was required for the use we do in brave. Chromium change: https://chromium.googlesource.com/chromium/src/+/6cc428454a87621f6cefbc08050ca53ded4cfca7 commit 6cc428454a87621f6cefbc08050ca53ded4cfca7 Author: danakj <[email protected]> Date: Fri Sep 13 20:46:38 2024 +0000 Import zerocopy and byteorder crates The zerocopy crate is used by rand now (via ppv-lite86) so we pull it in to be able to roll our 3p dependencies to their latest versions. As it is developed by and used internally at Google, we'll see future crates make use of it as well. The zerocopy crate provides safe abstractions to handle data in a zero-copy manner, which we would grately prefer over writing unsafe Rust code, so we allow the crate for 1p use while importing it. Unsafe review for byteorder is done in this CL. Change-Id: I077b0596bd3738ecd26da8ad2aab168626f23d2f

This is another case where we are required to add one of the headers to our inclusions to avoid unwanted substitution.

The return value for `GetInstalledFile` has changed, which has broken the override, as it relies on the substitution declaration to have the same return type. Chromium change: https://chromium.googlesource.com/chromium/src/+/4bc4563fa88f842b1fa05ee6ec28f80c26a48f6f commit 4bc4563fa88f842b1fa05ee6ec28f80c26a48f6f Author: Joshua Pawlicki <[email protected]> Date: Thu Sep 12 19:14:48 2024 +0000 update_client: Simplify ActionRunner. Also eliminate the implementation of GetInstalledFile for the extension updater. The diff system no longer calls it and the only remaining caller is ActionRunner, which we don't need to support for extensions. Also add some checks against parent and absolute paths in the run command. (We don't need these and maybe it's unwise to have the client accept them from the server for insider risk reasons.) The original motivation of the CL was to continue to eliminate refs to Component (ActionRunner held a raw_ref.) Bug: 353249967

Upstream has enabled this warning, which has failed in some cases in our codebase. Chromium change: https://chromium.googlesource.com/chromium/src/+/8104564104c2c2e5f3961623707ee5fc55e2706c commit 8104564104c2c2e5f3961623707ee5fc55e2706c Author: Devon Loehr <[email protected]> Date: Fri Sep 13 19:20:46 2024 +0000 Enable deprecated-this-capture warning We've finally eliminated all lambdas which implicitly capture the `this` pointer by value, so time to enable the warning globally. Includes a fix for one last file which snuck in since my last fix. Change-Id: Ib601567205f0aab2992bac0c60fe0a2b4e63465b Fixed: 351004963

`BravePrivacySandboxSettings` stubs out everything to false, as we disable this feature. Chromium change: https://chromium.googlesource.com/chromium/src/+/b67df9e045d89274e7641b8a077c5bfafe762886 commit b67df9e045d89274e7641b8a077c5bfafe762886 Author: Xiaochen Zhou <[email protected]> Date: Fri Sep 13 18:53:36 2024 +0000 [Privacy Sandbox] Implement IsLocalUnpartitionedDataAccessAllowed attestation check Implement the PrivacySandboxSettings layer attestation check for the new attestation API: LOCAL_UNPARTITIONED_DATA_ACCESS The change in this CL does not have any effect until the upstream attestation check in ChromeContentBrowserClient is implemented and plug into the API call site. The logics of IsLocalUnpartitionedDataAccessAllowed mimics IsSharedStorageAllowed. Except it does not implement the debug functionality. Also there is a TODO crbug.com/365788691 for gating this feature on 3PC setting. This CL also adds the histogram metric for this new attestation API. See https://protobuf.dev/programming-guides/proto3/#updating:~:text=If%20you%20add,section%20for%20details. See https://github.com/WICG/fenced-frame/blob/master/explainer/fenced_frames_with_local_unpartitioned_data_access.md. Bug: 361375807

This change is of no consequence to the only override in the codebase for this function, because the argument was not being used. Chromium change: https://chromium.googlesource.com/chromium/src/+/4a0ed02d15c72920ae48b2a1987e867d096ed1f9 commit 4a0ed02d15c72920ae48b2a1987e867d096ed1f9 Author: Kevin McNee <[email protected]> Date: Thu Sep 12 20:26:29 2024 +0000 Remove unused inner WebContents attach params Following the removal of the portals implementation, the remaining callers of AttachInnerWebContents don't have remote frame interfaces to bind. None of the observers of InnerWebContentsAttached use `is_full_page`. Bug: 40287334

Chromium change: https://chromium.googlesource.com/chromium/src/+/8c8b25bb5e964207b68cc982d718f161ef601f29 commit 8c8b25bb5e964207b68cc982d718f161ef601f29 Author: rbpotter <[email protected]> Date: Wed Sep 11 17:28:44 2024 +0000 Downloads: Cleanup Polymer leftovers - Check in .html.ts file for downloads item - Migrate icons to cr-iconset - Remove Polymer ts_dep, except in branded builds where it is still needed for the branded iconset. Bug: 40943652

This was introduced some time ago, however it has been reverted on upstream. This change readjusts our own overrides for this type. Chromium change: https://chromium.googlesource.com/chromium/src/+/e861d646ca7fa8d8e5dbeee54e9e88d50433da54 commit e861d646ca7fa8d8e5dbeee54e9e88d50433da54 Author: Alex Ilin <[email protected]> Date: Mon Sep 16 09:51:44 2024 +0000 Revert "Split API key caches to load them separately." This reverts commit 1f30fba88b01443407adaf2a6e1852b8beee8744. Reason for revert: splitting the cache didn't help and we'd like to initialize all values at the same time again. This is not a clean revert because of merge conflicts + keeping changes to tests. Original change's description: > Split API key caches to load them separately. > > This CL splits the API caches into 4 different objects: the goal is to attempt to load them as lazily as possible, so that the main API key is loaded after the FeatureList is initialized on ChromeOS. > > This CL assumes that there one of the other keys stored in the old > `g_api_key_cache` is used early during the initialization process on > ChromeOS and this is why the entire cache of API Keys is loaded earlier > than the feature flags are loaded. This CL is an attempt to load the > main APIKey lazily (e.g. decouple its load from `metrics_key` which > seems to be used early during the initialization sequence). > > To validate this approach, we expect there to be 0 entries in histogram > Signin.APIKeyMatchesFeatureOnStartup for bucket "false" when the > experiment is enabled. > > Bug: TBD > Change-Id: I9da5cc5024bb397e2158b584da33d8519e9388b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5830788 > Commit-Queue: Mihai Sardarescu <[email protected]> > Reviewed-by: Alex Ilin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1349928} Bug: TBD

Upstream has introduced a corresponding `GetForProfile` to `GetForBrowserState` static implementations. Some of these functions are shadowed with a different implementation on brave's build. This change corrects our own shadowing to mach the upstream change. Chromium change: https://chromium.googlesource.com/chromium/src/+/60e41b00436d57c7a7ff5c4671cb6c5e970ae9d4 commit 60e41b00436d57c7a7ff5c4671cb6c5e970ae9d4 Author: Mark Cogan <[email protected]> Date: Wed Sep 11 15:53:28 2024 +0000 Forward GetForBrowserState() getters in keyed services. For every keyed service with a GetForBrowserState() getter, this CL adds a GetForProfile() getter as the authoritative implementation and updates GetForBrowserState() to forward to this method. Also: * The GetForBrowserState params are changed to be "ProfileIOS* profile". * In many cases, the ordering of methods in the keyed service header are standardized and spurious comments are removed. * In many cases, comments referencing browser states are updated to reference profiles. * ReadingListModelFactory::GetAsDualReadingListModelForBrowserState is migrated (all call sites updated) to ...ModelForProfile(). * Other small cleanups. Low-Coverage-Reason: LARGE_SCALE_REFACTOR Bug: 358335594

These tests were crashing on Android: PageMetricsUnitTest.DomainsLoadedCount PageMetricsUnitTest.BookmarkCount PageMetricsUnitTest.FirstPageLoadTimeTooLate PageMetricsUnitTest.FirstPageLoadTimeImmediate PageMetricsUnitTest.PagesLoadedCount PageMetricsUnitTest.FirstPageLoadTimeLater BraveSearchProviderTest.SearchDoesNotIncludeHistoryWhenHistoryDisabled BraveSearchProviderTest.SearchIncludesHistoryWhenHistoryEnabled Tests were crashing because they cannot create SearchEngineCountryDelegateImpl object. Crash didn't happen on cr129 because SearchEngineChoiceService::GetCountryIdInternal returnd before Java_SearchEngineChoiceService_requestCountryFromPlayApi call. Related Chromium change: chromium/chromium@17b1d05 [waffle]Remove search_engines::IsChoiceScreenFlagEnabled() Remove the function and related calls and params. This is because the kSearchEngineChoiceTrigger feature is now fully launched. Fixed: b:364815974 Change-Id: I1b3c253c656c76246fae96486b2863632878f17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837290

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/560a9bb2a389f708d7c29eb486fd4009e51fd837 Remove unused uma from NTP#initializeMainView. Change-Id: I4ec01cb4f1361981a0cbb4397fc4008ac9c412d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861609

We must it duplicate at our brave/android/java/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a269abacce33fa1cdb136a4c4b0ef6b6d20d4d0b [E2E] Draw Incognito NTP edge to edge This change plumb through the EdgeToEdgeController to Incognito NTP (INTP). When drawing edge to edge, add the bottom inset padding to INTP's scroll view, and #setClipToPadding(false). This makes the view drawing into the nav bar region while ensure the controls in the page remains reachable when scrolled to the bottom. The change also introduces an interface for NativePage to check if it is compatible for edge to edge. Currently only INTP is supported, and change is guarded behind DrawKeyNativePageToEdge. The preview: https://screenshot.googleplex.com/BYiJ8TkNP4Q3pqa Bug: 339025702 Change-Id: I86459682089adc9f8898382fb90278136444c705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5847378

…dgeControllerSupplier Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a269abacce33fa1cdb136a4c4b0ef6b6d20d4d0b [E2E] Draw Incognito NTP edge to edge This change plumb through the EdgeToEdgeController to Incognito NTP (INTP). When drawing edge to edge, add the bottom inset padding to INTP's scroll view, and #setClipToPadding(false). This makes the view drawing into the nav bar region while ensure the controls in the page remains reachable when scrolled to the bottom. The change also introduces an interface for NativePage to check if it is compatible for edge to edge. Currently only INTP is supported, and change is guarded behind DrawKeyNativePageToEdge. The preview: https://screenshot.googleplex.com/BYiJ8TkNP4Q3pqa Bug: 339025702 Change-Id: I86459682089adc9f8898382fb90278136444c705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5847378

It is not static now and have a new tracker arg. Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/828eb6d14543d75671991083fd162b3308bcadbe [DefaultBrowser] Add helper for the role manager restriction This CL adds a helper DefaultBrowserPromoUtils#shouldShowOtherPromo to decide if other default browser promos can be shown. The conditions mean to ensure that we only show other promo when the role manager promo can't be shown either because of reaching the max count or role manager not available in the current system. It also adds the a feature engagement event to ensure the new promo can only be shown if the role manager promo not shown in the 7 days window. Bug: 364906215 Change-Id: If5684ee24ff87d193939dd9b8c6ae6d2a8af783c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839024

Chromium change: https://source.chromium.org/chromium/chromium/src/+/52962da478ed750038f966c386c4ee0ff2d73837 Always apply luminance calculation to navigation bar icons Currently, the navigation bar icons only respond to the color of the navigation bar during animations. Since animations are being disabled for the navbar coloring experiment, it's important that the luminance calculation to properly color the navigation bar icons is applied all the time, not just during animations. Bug: 364228106, 40925025

This reverts commit 0134235.

This reverts commit 18ae72b.

This hasn't been working for several releases and, with the switch to Lit, it's no longer compiling. After speaking with Jay, decided that the simplest way forward is to remove the override and fix it in master once cr130 is merged. Tracked via brave/brave-browser#41153

METADATA ERROR: missing required fields in README.chromium in brave/third_party/rust/*** These libs and it's metadata are at upstream src/third_party/rust

…moUtils, it caused crash With the commit "[Android] DefaultBrowserPromoUtils.prepareLaunchPromoIfNeeded changed" debug app crashes at the start with an error `java.lang.VerifyError: Rejecting class org.chromium.chrome.browser.tabbed_mode.BraveTabbedRootUiCoordinator that attempts to sub-type erroneous class` attempt to build release app fails with error ``` Missing class org.chromium.chrome.browser.ui.default_browser_promo.BraveDefaultBrowserPromoUtils (referenced from: boolean org.chromium.chrome.browser.tabbed_mode.l.L(org.chromium.chrome.browser.profiles.Profile)) Missing method boolean org.chromium.chrome.browser.ui.default_browser_promo.BraveDefaultBrowserPromoUtils.prepareLaunchPromoIfNeeded(android.app.Activity, org.chromium.ui.base.WindowAndroid, org.chromium.components.feature_engagement.Tracker, boolean) (referenced from: boolean org.chromium.chrome.browser.tabbed_mode.l.L(org.chromium.chrome.browser.profiles.Profile)) ``` This commit disables BraveDefaultBrowserPromoUtils patch to make the app be able to launch.

[Android] TranslateCompactInfoBar class was removed (Verified the transalte infobar bubble is still shown) Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/333ffb2d4a93d2ce9e9a5fabdf1e593d6d062e9d Remove and clean up old Translate Infobar code. Leaving translate_infobar_delegate because there are still iOS dependencies attached. Fixed: 353735844 Bug: 40213244 Change-Id: Ief6abe1485ef372f1ac44426b1edeb3b69b89208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5727132

…0.6725.1.

`top_frame_origin` is not being passed as a reference to an optional anymore, as that can lead to unwanted copies. This change corrects our overrides to that function to match the signature upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/eeda933c994ab5e0e9612bc695b78e38231a8bd1 commit eeda933c994ab5e0e9612bc695b78e38231a8bd1 Author: Chris Fredrickson <[email protected]> Date: Tue Sep 17 14:06:47 2024 +0000 Use base::optional_ref<T> instead of std::optional<T>& std::optional<T> is a value that might absent, whereas base::optional_ref<T> is a reference that might be absent. Thus, use of std::optional<T> results in an unnecessary copy when implicitly converting from a T&; base::optional_ref avoids that copy. (A function parameter of type base::optional_ref<T> is similar to a parameter of type T*, except that the base::optional_ref allows the use of temporaries.) Change-Id: Ib627b18105e6a6d18d892f4731f5049b183a9df0

With the use of span as an outparam, it becomes possible to better iterate over the items. Chromium change: https://chromium.googlesource.com/chromium/src/+/b3255fdcb98caf809e094ff2016930f8abf96e74 commit b3255fdcb98caf809e094ff2016930f8abf96e74 Author: Fredrik Söderquist <[email protected]> Date: Tue Sep 17 00:16:36 2024 +0000 spanification: WTF::String::CreateUninitialized() Forward to the span<> variant on StringImpl. Bug: 351564777

Chromium change: https://source.chromium.org/chromium/chromium/src/+/924617d4a513876f7cf0097d073a037d08b9eb31 commit 924617d4a513876f7cf0097d073a037d08b9eb31 Author: dpapad <[email protected]> Date: Tue Sep 17 17:57:45 2024 +0000 Settings: Replace remaining <iron-icon src=...> usages with cr-icon. `src=...` is not supported by cr-icon. In order to accommodate, using an <img> element directly when `src=...` is needed (in both cases it was done to display throbber_small.svg). Bug: 40943652

Chromium changes: https://source.chromium.org/chromium/chromium/src/+/1ed8db05a7a2c2affbff615d8aaea759ac87bade commit 1ed8db05a7a2c2affbff615d8aaea759ac87bade Author: Erik Chen <[email protected]> Date: Tue Sep 17 07:31:34 2024 +0000 Reduce fragility in SidePanelCoordinator (part 7 / N) This CL is a refactor with no intended user-visible impact. This CL deletes the view property SidePanelContentState. This is only read by SidePanel and only set by SidePanelCoordinator. By removing the view property we remove an unnecessary layer of indirection. This is replaced by Open and Close methods on SidePanel which SidePanelCoordinator calls. This CL adds a state member to SidePanel to track and expose the internal state machine. State is one of: kClosed, kOpening, kOpen, kClosing. SidePanelCoordinator is the only entity that should be controlling visibility of SidePanel. All other calls to UpdateVisibility() were removed. These calls appear to be side effects of relying of view-properties to propagate state changes. Bug: 363743081 https://source.chromium.org/chromium/chromium/src/+/31a977c143b574bc9d85e1979e2483b3369daf54 commit 31a977c143b574bc9d85e1979e2483b3369daf54 Author: Erik Chen <[email protected]> Date: Wed Sep 18 04:28:39 2024 +0000 Reduce fragility in SidePanelCoordinator (part 9 / N) This CL is a refactor with no intended behavior change. This CL moves the class SidePanelContentSwappingContainer from SidePanelCoordinator to SidePanel. Bug: 363743081

Chromium change: https://source.chromium.org/chromium/chromium/src/+/2646de6874e08c0da01754b72486c29a01cdedd1 commit 2646de6874e08c0da01754b72486c29a01cdedd1 Author: Emily Shack <[email protected]> Date: Tue Sep 17 22:09:42 2024 +0000 Declutter: Allow opening to a specific feature Adds a profile pref for the feature the tab organization tab within the tab search bubble should display when opened. This follows the pattern used for opening the bubble to a specific tab. For now, this is used by auto tab groups entry points to bypass the selector. Future use cases such as the chip and any other new entrypoints will similarly be able to open the bubble directly to declutter. Bug: 366236403

Chromium change: https://source.chromium.org/chromium/chromium/src/+/7a7f7387efa2e2a34fe41cbef79a6f7660ce3328 commit 7a7f7387efa2e2a34fe41cbef79a6f7660ce3328 Author: S. Ganesh <[email protected]> Date: Tue Sep 17 17:18:44 2024 +0000 Add the ability to set a description for the InstallServiceWorkItem Bug: 343638931

On MacOS/iOS: ERROR at //chrome/updater/mac/BUILD.gn:13:1: Value collision. import("//chrome/updater/branding.gni") ^------------------------------------- This import contains "keystone_app_name" See //brave/chromium_src/chrome/updater/branding.gni:18:23: defined here. keystone_app_name = "BraveSoftwareUpdate" ^-------------------- Which would clobber the one in your current scope See //chrome/enterprise_companion/branding.gni:32:23: defined here. keystone_app_name = "ChromiumSoftwareUpdate" ^----------------------- Executing import should not conflict with anything in the current scope unless the values are identical. See //chrome/updater/BUILD.gn:23:14: which caused the file to be included. deps = [ "//chrome/updater/mac" ] ^--------------------- Chromium change: https://source.chromium.org/chromium/chromium/src/+/bd96319778e6f280a4915b29f1ca16c16d6f00af commit bd96319778e6f280a4915b29f1ca16c16d6f00af Author: Noah Rose Ledesma <[email protected]> Date: Tue Aug 6 21:41:11 2024 +0000 Create pkg installer for MacOS Add a build rule which creates a pkg installer for MacOS. The pkg installer copies the application bundle to a staging directory (adj. to the installation), and runs the enterprise_companion binary with the install flag, akin to O4's installer. Behind the install flag, the logic for Linux's installer is now shared with Mac to simply copy the executable to the install directory and configure permissions. Finally, a new integration test target was added to provide coverage of this installation experience. Integration tests are distinct from unit tests in that they will require root/admin privileges. Bug: 344878963

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 130 to Chromium 131. #25662

Upgrade from Chromium 130 to Chromium 131. #25662

Commits on Sep 20, 2024

Upgrade from Chromium 130 to Chromium 131. #25662

Are you sure you want to change the base?

Upgrade from Chromium 130 to Chromium 131. #25662

Commits on Sep 20, 2024