Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug #280 -- searches using subelement_key_name parameter now only return current versions #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bretdawson
Copy link
Contributor

Hi everybody,

This bug affects searches for stories and media using the subelement_key_name parameter.

At the moment, documents that contained a subelement in a previous version, but do not contain it in the current one, are returned incorrectly in a search.

This patch just adds a check to be sure the subelement records are active.

Thanks so much,

Bret

@theory
Copy link
Member

theory commented Nov 11, 2011

Hrm. Those TRUEs shouldn't be in there; I don't believe they'll work on MySQL, will they? I think you can use '1'.

@bretdawson
Copy link
Contributor Author

Double hm. There are existing TRUEs for the subelement_id parameter, so probably both subelement_key_name and subelement_id searches have been broken for MySQL for a while.

But! MySQL booleans seem a little better than they used to:

http://dev.mysql.com/doc/refman/5.0/en/numeric-type-overview.html

I'll install MySQL and see how it copes in real life, but it looks promising.

@gregheo
Copy link
Contributor

gregheo commented Nov 11, 2011

No test?!? :)

On 2011-11-11, at 5:23 PM, Bret Dawson
[email protected]
wrote:

You can merge this Pull Request by running:

git pull https://github.com/bretdawson/bricolage 280

Or you can view, comment on it, or merge it online at:

#38

@bretdawson
Copy link
Contributor Author

OK, I've tried the whole thing with MySQL and the verdict is in: True and False work just fine, and so do TRUE and FALSE and true and false.

Greg, you are going to loooooove the test. One day.

@theory
Copy link
Member

theory commented Feb 13, 2015

So, no need for this change, @bretdawson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants