Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant \expandafter definition #2368

Merged
merged 2 commits into from
May 29, 2024

Conversation

dginev
Copy link
Collaborator

@dginev dginev commented May 27, 2024

Spotted while porting. There appear to be two \expandafter definitions following each other.

As the first one wasn't getting used (immediately overwritten by the second), this PR removes it for clarity.

@dginev
Copy link
Collaborator Author

dginev commented May 28, 2024

I also removed a redundant \relpenalty (TeXbook value seems to be 500)

@dginev
Copy link
Collaborator Author

dginev commented May 29, 2024

There are also two definitions of \newread and \newwrite in plain.pool.ltxml, but I am not sure which of the two variants should be kept? May be worth a look.

@brucemiller
Copy link
Owner

I'll have to remember to take a look at \newread & \newrite, as there are some subtle differences between plain.tex and plain.pool approaches which need sorting.

@brucemiller
Copy link
Owner

Looks good; thanks!

@brucemiller brucemiller merged commit 40e9fa8 into brucemiller:master May 29, 2024
13 checks passed
@brucemiller brucemiller deleted the rm-redundant-expandafter branch May 29, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants