-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base primitive improvements #2369
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d6a2337
Tweak fontname recognition for cmti (text italic)
brucemiller 6315734
Move initialization of UC/LC to State.pm
brucemiller 7247c64
Move a couple of helpers from plain to TeX_Math
brucemiller 0b3cc30
Various tweaks & new defns: \nonscript, fix \delcode, \mathbin etal g…
brucemiller c4ed084
Define an expanded general text parameter type (XGeneralText) that ex…
brucemiller 04bd256
autoopened nodes can be autoclosed
brucemiller 105cc78
DefMath can coerce more symbols to simpler primitives (rather than co…
brucemiller 6cd1f12
Better math char decoding
brucemiller 9ab8538
Make \mathopen, etc digest the argument (but something odd with \mathop)
brucemiller d217aa3
Improved \left,\right handling to deal with \delimiter and others; Ne…
brucemiller 848364f
Update test cases for more consistently preserved (though dubious) na…
brucemiller bf091b8
Add left/right \delimiter test
brucemiller 07639dd
TeXDelimiter parameter type reverts w/o braces
brucemiller 048674d
Autoopened text nodes can autoclose, but not necessarily others
brucemiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that the implied "default" now is for any Tag() marked as
autoOpen => 1
, it will also lead toautoClose => 1
?I see we have a special attribute
_noautoclose
that prevents autoclose, but it makes me wonder if we should also respect an explicitautoClose => 0
from Tag(). Or document that we won't, or...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you put it like that, it does seems too much, although it's probably correct most/all of the time? The problem element in this case was the
ltx:text
opened for font switches, so better to explicitly mark them as auto-closable, as well. patched...