handled case sensitivity #2245
Merged
handled case sensitivity #2245
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
natalieparellano
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Looks good to me. Thank you @keshavdalmia10!
I think we just need to fix DCO: https://github.com/buildpacks/pack/pull/2245/checks?check_run_id=28451969833
Signed-off-by: Keshav Dalmia <[email protected]>
keshavdalmia10
force-pushed
the
cache_flag_case_sensitivity_2229
branch
from
06711ee
to
1e26662
Compare
Hi @natalieparellano , I have signed off. Thanks for approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling pack build using the --cache flag to bind a directory containing uppercase letters, pack incorrectly converts the directory to lowercase. Now this is handled. Have removed the
.toLowerCase()function fromvalue.Output
Before
After
Documentation
Related
Resolves #2229