fix(gha): linting and general execution fixed

camunda · Sep 16, 2024 · 3af677d · 3af677d
1 parent 6b43877
commit 3af677d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/.github/workflows/nightly_aws_operational_procedure.yml b/.github/workflows/nightly_aws_operational_procedure.yml
@@ -139,15 +139,9 @@ jobs:
         c8-version:
         # renovate: datasource=helm depName=camunda-platform registryUrl=https://helm.camunda.io versioning=regex:^10(\.(?<minor>\d+))?(\.(?<patch>\d+))?$
         - 10.4.0
-
-        # we don't include SNAPSHOT in PR due to the instability of its nature except if it's explicitly mentioned
-        isPR:
-        - ${{ github.event_name == 'pull_request' && !contains(github.head_ref, 'SNAPSHOT') }}
-        exclude:
-        - c8-version: SNAPSHOT
-          isPR: true
-        - c8-version: SNAPSHOT-NEW
-          isPR: true
+        # workaround to let the c8_namespace_parser script still create the snapshot namespaces for DNS chaining
+        # yamllint disable-line
+        #- SNAPSHOT
 
     steps:
     ################## Checkout ##################

diff --git a/.github/workflows/scripts/c8_namespace_parser.sh b/.github/workflows/scripts/c8_namespace_parser.sh
@@ -14,7 +14,7 @@ fi
 
 # For new versions bump -A argument by 1
 # It greps the c8-version and the next x lines
-versions=$(grep 'c8-version:' -A 4 "$1" | awk '/c8-version:/ {flag=1; next} flag {print $2}')
+versions=$(grep 'c8-version:' -A 5 "$1" | awk '/c8-version:/ {flag=1; next} flag {print $2}')
 
 variables=("CLUSTER_0_NAMESPACE" "CLUSTER_1_NAMESPACE" "CLUSTER_0_NAMESPACE_FAILOVER" "CLUSTER_1_NAMESPACE_FAILOVER")
 

diff --git a/aws/dual-region/scripts/export_environment_prerequisites.sh b/aws/dual-region/scripts/export_environment_prerequisites.sh
@@ -26,5 +26,5 @@ export CAMUNDA_NAMESPACE_1_FAILOVER=camunda-paris-failover
 
 # The Helm release name used for installing Camunda 8 in both Kubernetes clusters
 export HELM_RELEASE_NAME=camunda
-# renovate: datasource=helm depName=camunda-platform registryUrl=https://helm.camunda.io
+# renovate: datasource=helm depName=camunda-platform registryUrl=https://helm.camunda.io versioning=regex:^10(\.(?<minor>\d+))?(\.(?<patch>\d+))?$
 export HELM_CHART_VERSION=10.4.0
diff --git a/test/multi_region_aws_camunda_test.go b/test/multi_region_aws_camunda_test.go
@@ -25,7 +25,7 @@ const (
 )
 
 var (
-	// renovate: datasource=helm depName=camunda-platform registryUrl=https://helm.camunda.io
+	// renovate: datasource=helm depName=camunda-platform registryUrl=https://helm.camunda.io versioning=regex:^10(\.(?<minor>\d+))?(\.(?<patch>\d+))?$
 	remoteChartVersion = helpers.GetEnv("HELM_CHART_VERSION", "10.4.0")
 	remoteChartName    = helpers.GetEnv("HELM_CHART_NAME", "camunda/camunda-platform") // allows using OCI registries
 	globalImageTag     = helpers.GetEnv("GLOBAL_IMAGE_TAG", "")                        // allows overwriting the image tag via GHA of every Camunda image