Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning added to NOTES about installationType #2328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Sep 10, 2024

Which problem does the PR fix?

Related to #2286

global.multiregion.installationType is going away, so if anyone uses this option, they should get a notice that says:

[camunda][warning]
DEPRECATION NOTICE: Starting from appVersion 8.7, the Camunda Helm chart will no longer support the global.multiregion.installationType option. This is replaced with a new procudure for managing multi-region installations documented here:
https://docs.camunda.io/docs/self-managed/operational-guides/multi-region/dual-region-operational-procedure/
Please unset this option to remove the warning.

What's in this PR?

if the option is set, print the warning.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@jessesimpson36 jessesimpson36 self-assigned this Sep 20, 2024
@jessesimpson36 jessesimpson36 marked this pull request as ready for review September 20, 2024 18:52
@jessesimpson36 jessesimpson36 requested a review from a team September 20, 2024 18:52
@jessesimpson36 jessesimpson36 added the documentation Improvements or additions to documentation label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant