Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a single ActivateVolumeOptions struct for the ActivateVolumeWith* family #116

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Have a single ActivateVolumeOptions struct for the ActivateVolumeWith* family #116

merged 2 commits into from
Sep 25, 2020

Commits on Sep 25, 2020

  1. Have a single ActivateVolumeOptions struct for the ActivateVolumeWith… 

    …* funcs

Also rename PIN in its definition to UserPassprase to move toward
better and also more abstract naming.

Same in the corresponding RecoveryKeyUsageReason code.

Se also issue #113
    @pedronis
    pedronis committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    fbec76e View commit details
    Browse the repository at this point in the history

  2. improve comments based on feedback, drop User from UserPassphrase 

    UserPassphrase is fairly long and it's unclear whether it always
be strictly from a user

thanks @bboozzoo, @anonymouse64
    @pedronis
    pedronis committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    8995bba View commit details
    Browse the repository at this point in the history