Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edit-registries command #5050

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Supports the first half of the edit-registries command where a user can retrieve and edit a registries set.

The second half will be implemented in #5018.

Builds on top of #5049, so ignore the first commit.

I broke this up into 2 commits to make reviewing easier.

Fixes #5020
(CRAFT-3333)

Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added a note about changing a help message that's not very helpful.

"""Edit a registries set."""

name = "edit-registries"
help_msg = "Edit registries"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something that's not the same as the option? "Edit a registries set" could work, or even better if you could change the word "edit" to something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registries: collect and edit registries
3 participants