o/snapstate: revert snaps with components #14510
Open
+405
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewphelpsj
force-pushed
the
revert-comps
branch
3 times, most recently
from
6b9f536
to
8169c0b
Compare
andrewphelpsj
force-pushed
the
revert-comps
branch
3 times, most recently
from
89ba893
to
94f13f6
Compare
pedronis
reviewed
Sep 20, 2024
pedronis
reviewed
Sep 20, 2024
| @@ -424,6 +424,11 @@ func (m *SnapManager) doLinkComponent(t *state.Task, _ *tomb.Tomb) error { | |||
| return err | |||
| } | |||
|
|
|||
| // during a revert, components should already be linked | |||
| if snapsup.Revert { | |||
There was a problem hiding this comment.
any reason not to skip adding the tasks instead in the first place?
There was a problem hiding this comment.
Good question, I feel like I originally had a reason for taking this approach, but it doesn't seem relevant now. I've reworked this to not create the tasks.
andrewphelpsj
force-pushed
the
revert-comps
branch
from
94f13f6
to
48a4744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to revert snaps with components, which results in just switching to the set of components that was installed when that revision of the snap was the current one.