overlord/fdestate: keep FDE state up to date #14516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Run Nested -auto-
valentindavid
changed the title
valentindavid
force-pushed
the
valentindavid/sync-fde-state
branch
8 times, most recently
from
36f5c11
to
96fe3c2
Compare
valentindavid
force-pushed
the
valentindavid/sync-fde-state
branch
3 times, most recently
from
2331c1f
to
728ff63
Compare
Ensure() initializes the empty profiles, and reseal updates them.
valentindavid
force-pushed
the
valentindavid/sync-fde-state
branch
from
728ff63
to
14d22b2
Compare
valentindavid
commented
Sep 20, 2024
| } | ||
| } | ||
|
|
||
| type KeyDigest struct { |
There was a problem hiding this comment.
This might be a type that should be handled in secboot. And we just use json.RawMessage for it.
valentindavid
commented
Sep 20, 2024
Comment on lines
+61
to
+64
| if !locked { | ||
| m.state.Lock() | ||
| defer m.state.Unlock() | ||
| } |
There was a problem hiding this comment.
This is not elegant. But I am not sure how to handle it correctly. We do resealing sometimes locked, sometimes not.
There was a problem hiding this comment.
do we know where is it called with the state really already unlocked?
valentindavid
commented
Sep 20, 2024
Comment on lines
+188
to
+197
| dataUUID, dataErr := disksDmCryptUUIDFromMountPoint(dirs.GlobalRootDir) | ||
| saveUUID, saveErr := disksDmCryptUUIDFromMountPoint(dirs.SnapSaveDir) | ||
| if errors.Is(saveErr, &disks.ErrMountPointNotFound{}) { | ||
| // TODO: do we need to care about old cases where there is no save partition? | ||
| return nil | ||
| } | ||
|
|
||
| if errors.Is(dataErr, disks.ErrNoDmUUID) && errors.Is(saveErr, disks.ErrNoDmUUID) { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I think we should look at the sealing method with device.SealedKeysMethod instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure() initializes the empty profiles, and reseal updates them.
This is on top of #14400