-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement frontend for test execution review #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Most are small points but one issue is about passing artefactId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better, just a few more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the c3 link is still there in the code, but I don't see it in the screenshots you posted. Is that just something off with the screenshot, or was there some UI change that somehow removed the c3 link here?
The C3 Link button is conditionally rendered, it just happened that none of these test executions have it set up in the database, so it is not shown on the frontend either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, good job!
This PR resolves RTW-204 and implements the frontend functionality for test execution review.
Implementation Changes
As part of this change, a few things have been updated:
Screenshots
Design changes
I have changed the design slightly, as I couldn't find a way to use
YaruPopupMenuButton
which is specified in the design to be a standard button like TextButton.Unresolved issues
When updating an existing Test Execution Review, I managed to load the selected decisions. However, I couldn't find a way to load the review comment into the
TextField
widget.