-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove lodash as dependency #2993
base: master
Are you sure you want to change the base?
refactor: remove lodash as dependency #2993
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danielsogl, any specific reason for removing lodash? I feel like it can bring value to a lot of the components where we need to do array manipulation or deep copies. I agree we can implement our own utilities, but using lodash would be more safer and stable.
The tests seem to pass so it's definitely safe to remove, just want to know your reasoning and any complications you have run into.
@Akshat55 |
You're right, my initial plan was to replace |
Closes carbon-design-system/carbon-components-angular#
Removes lodash as a dependency
Changelog