Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): center icon inside danger ghost icon only buttons #16923

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aad3d08
fix(client): bug 16841 by removing padding inline end
AliAldobyan Jul 8, 2024
07aecaa
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Jul 8, 2024
95e9d5a
fix(button): center icon inside danger ghost icon only buttons
AliAldobyan Jul 9, 2024
1f86e8d
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Jul 11, 2024
2f0374a
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Jul 21, 2024
590a94d
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 1, 2024
39e4d67
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 4, 2024
54d4bde
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 7, 2024
e0e67fb
fix(button): center icon inside danger ghost icon only buttons
AliAldobyan Aug 19, 2024
0bc7d93
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 19, 2024
40f3a9e
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 20, 2024
1d20e8c
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 20, 2024
58ccd63
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 21, 2024
20c1df9
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Aug 25, 2024
11a3fa1
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Sep 3, 2024
0ee718e
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
AliAldobyan Sep 9, 2024
a013e60
Merge branch 'main' into fix_bug_the_icon_inside_IconButton_not_align…
tay1orjones Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -1588,6 +1588,15 @@
"code"
]
},
{
"login": "AliAldobyan",
"name": "Ali Al Dobyan",
"avatar_url": "https://avatars.githubusercontent.com/u/17975825?v=4",
"profile": "https://github.com/AliAldobyan",
"contributions": [
"code"
]
},
{
"login": "Adam-Shea",
"name": "Adam Shea",
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
<td align="center"><a href="https://github.com/nandininarayanofficial"><img src="https://avatars.githubusercontent.com/u/165769075?v=4?s=100" width="100px;" alt=""/><br /><sub><b>nandininarayanofficial</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=nandininarayanofficial" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/digiacomo-a"><img src="https://avatars.githubusercontent.com/u/117646602?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Andrea DG</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=digiacomo-a" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/lluisrojass"><img src="https://avatars.githubusercontent.com/u/15043356?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Luis</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=lluisrojass" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/AliAldobyan"><img src="https://avatars.githubusercontent.com/u/17975825?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Ali Al Dobyan</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=AliAldobyan" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/lharrison13"><img src="https://avatars.githubusercontent.com/u/172074450?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Luke Harrison</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=lharrison13" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/tekno0ryder"><img src="https://avatars.githubusercontent.com/u/8721803?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Ahmed Alsinan</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=tekno0ryder" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/Adam-Shea"><img src="https://avatars.githubusercontent.com/u/44814104?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Adam Shea</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Adam-Shea" title="Code">💻</a></td>
Expand Down
7 changes: 6 additions & 1 deletion packages/styles/scss/components/button/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@
);

> :first-child {
margin-block-start: convert.to-rem(1px);
min-inline-size: convert.to-rem(16px);
}

Expand All @@ -174,6 +173,12 @@
&.#{$prefix}--btn--danger--ghost .#{$prefix}--btn__icon {
margin: 0;
}

&.#{$prefix}--btn--danger--ghost {
padding-inline-end: calc(
layout.density('padding-inline') - convert.to-rem(16px)
);
}
}

// Adjust icon positioning in small, medium variants only
Expand Down
Loading