fix(FilterableMultiSelect): call onMenuChange when mouse click outside #17136
Conversation
This fixes an issue where a mouse click event outside of the menu does not call the `onMenuChange` callback when the menu is open. Fixes carbon-design-system#16896
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @gi , could you please create a test story to test this fix? |
This adds an action recorder for `onMenuChange` in storybook.
|
@Gururajj77 Sure thing! I added an action to be recorded in the |
|
@tay1orjones Do you have a minute to review this three-line change? It's blocking my team from upgrading past |
|
The CI failure just requires that visual changes be reviewed/approved. |
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17136 +/- ##
==========================================
+ Coverage 76.83% 76.86% +0.02%
==========================================
Files 408 408
Lines 13949 13949
Branches 4276 4275 -1
==========================================
+ Hits 10718 10722 +4
+ Misses 3058 3054 -4
Partials 173 173 ☔ View full report in Codecov by Sentry. |
|
@tay1orjones @guidari Thank you for the reviews and approvals! Can either one of you or other maintainer merge this? I don't think I can do that. (Maybe you have a strategy for this, so sorry if I'm jumping the line.) |
5c70961
This fixes an issue where a mouse click event outside of the menu does not call the
onMenuChangecallback when the menu is open.Closes #16896
Changelog
Changed
Testing / Reviewing
Unit tests added.