Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-label): avt tests from slow to regular #17394

Conversation

ariellalgilmore
Copy link
Member

Closes #

the slow should not be needed here and removing it fixes a website issue where the accessibility tab shows "advanced states" not tested. Removing the slow adds them to the playwright .json output and will update the website information so the "advanced states" will display tested

Changelog

Changed

  • removed .slow from ai-label tests

Testing / Reviewing

make sure testing still passes consistently

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a887a98
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e318ddbba710000886d217
😎 Deploy Preview https://deploy-preview-17394--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a887a98
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e318dd221cc8000847842e
😎 Deploy Preview https://deploy-preview-17394--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review September 9, 2024 18:59
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner September 9, 2024 18:59
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (fdb31d9) to head (a887a98).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17394   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files         408      408           
  Lines       13973    13973           
  Branches     4341     4289   -52     
=======================================
  Hits        10735    10735           
- Misses       3064     3065    +1     
+ Partials      174      173    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Sep 18, 2024
Merged via the queue into carbon-design-system:main with commit 494e28c Sep 18, 2024
35 of 36 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/ai-label-remove-slow-from-test branch September 18, 2024 15:16
guidari pushed a commit to guidari/carbon that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants