fix: adds keyboard focus on tab navigation #17426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17426 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 408 408
Lines 13979 13979
Branches 4291 4339 +48
=======================================
Hits 10754 10754
+ Misses 3052 3051 -1
- Partials 173 174 +1 ☔ View full report in Codecov by Sentry. |
alisonjoseph
approved these changes
Sep 13, 2024
alisonjoseph
added
status: one more review 👀
and removed
status: ready for review 👀
labels
kennylam
approved these changes
Sep 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit Sep 16, 2024
bad3662
23 checks passed
guidari
pushed a commit
to guidari/carbon
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16886
Adds category title buttons to focus order
Changelog
Adds buttons to focus order via
TabIndexTesting / Reviewing
Go to
Header w/ Navigation, Actions and SideNavstory in UIShallNavigate the webpage via keyboard (Tab key) and verify that the focus does go to category title buttons