Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Connect] Added tagTitle prop to DismissibleTag #17436

Closed
wants to merge 6 commits into from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 13, 2024

Added tagTitle to code connect.

@guidari guidari requested a review from a team as a code owner September 13, 2024 11:56
@guidari guidari changed the title Tag figma [Code Connect] Added tagTitle prop to DismissibleTag Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit dd5ce6f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e428885cc6f4000762f418
😎 Deploy Preview https://deploy-preview-17436--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dd5ce6f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e42888ac4d1a00085ea6c8
😎 Deploy Preview https://deploy-preview-17436--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (72fb7c0) to head (dd5ce6f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17436   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files         408      408           
  Lines       13973    13973           
  Branches     4288     4336   +48     
=======================================
  Hits        10739    10739           
+ Misses       3061     3060    -1     
- Partials      173      174    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe "Tag title" is a Figma prop, if we need the component to always have a that prop as an example you would want to add it directly.

example: ({ ...props }) => <DismissibleTag tagTitle="optional title" {...props} />,

Screenshot 2024-09-13 at 7 57 35 AM

@guidari
Copy link
Contributor Author

guidari commented Sep 13, 2024

I don't believe "Tag title" is a Figma prop, if you just want the component to always have a that prop you would just add it in the example. example: ({ ...props }) => <DismissibleTag tagTitle="title" {...props} />,

Ohh NVM then. I thought I had to add the prop to the Code Connect also.

@guidari guidari closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants