Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(chat-button-toggle-skeleton): increase coverage #17440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

Closes #17431 #17432 #17429

Add test coverage for Chat Button, Chat Button Skeleton, and Toggle Skeleton

Changelog

New

  • added tests for Chat Button
  • added tests for Chat Button Skeleton
  • added Toggle Skeleton and created a tests folder inside Toggle

Testing / Reviewing

confirm testing passes
codecov should be 100% for these files

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9e12e6c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e4595c888fbf0008d40a77
😎 Deploy Preview https://deploy-preview-17440--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e12e6c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e4595c337e7e00088a2350
😎 Deploy Preview https://deploy-preview-17440--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.98%. Comparing base (fdb31d9) to head (9e12e6c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17440      +/-   ##
==========================================
+ Coverage   76.82%   76.98%   +0.15%     
==========================================
  Files         408      408              
  Lines       13973    13973              
  Branches     4341     4288      -53     
==========================================
+ Hits        10735    10757      +22     
+ Misses       3064     3043      -21     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review September 13, 2024 16:13
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner September 13, 2024 16:13
@ariellalgilmore ariellalgilmore changed the title chore(chat-button-toggle-skeleton): test updates test(chat-button-toggle-skeleton): increase coverage Sep 13, 2024
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage for ChatButton
2 participants