Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript types FluidTimePicker and FluidTimePickerSelect #17445

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

riddhybansal
Copy link
Contributor

Closes #17358
Closes #17359

Added Typescript types to FluidTimePicker and FluidTimePickerSelect and their skeleton state

Changelog

New

Added Typescript types to FluidTimePicker and FluidTimePickerSelect and there skeleton state
Converted index.js to tsx for both the component

Testing / Reviewing

FluidTimePicker and FluidTimePickerSelect and their skeleton state should work as intended with typescript support

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 733a47f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e7f57dac98ab00087de48f
😎 Deploy Preview https://deploy-preview-17445--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 733a47f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e7f57da01c990008d69bb3
😎 Deploy Preview https://deploy-preview-17445--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a8da9cb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66ec1fd454c56000088ee44b
😎 Deploy Preview https://deploy-preview-17445--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a8da9cb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66ec1fd40ef23a0008eb6fe2
😎 Deploy Preview https://deploy-preview-17445--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (d8e0045) to head (a8da9cb).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...src/components/FluidTimePicker/FluidTimePicker.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17445      +/-   ##
==========================================
+ Coverage   76.92%   76.95%   +0.02%     
==========================================
  Files         408      408              
  Lines       13979    13980       +1     
  Branches     4291     4344      +53     
==========================================
+ Hits        10754    10758       +4     
+ Misses       3052     3049       -3     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riddhybansal
Copy link
Contributor Author

riddhybansal commented Sep 16, 2024

Hi there I have one doubt over here I ahve passes id as empty string as it is a required prop, Can we do anything else instead of it ?

@tay1orjones
Copy link
Member

@riddhybansal I think FluidTimePickerProps needs to extend/inherit FluidTextInputProps

</FluidTimePickerSelect>
</FluidTimePicker>
);
// it('should add extra classes that are passed via className', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @riddhybansal is this testing failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I was testing something so commented that time need to uncomment it !!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluidTimePickerSelect FluidTimePicker
3 participants