Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makes aria-label prop optional in TabelExpandHeader #17467

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

2nikhiltom
Copy link
Contributor

Closes #17309

Makes aria-label prop optional

Changelog

aria-label prop optional
updated test cases to use aria-label instead if deprecated ariaLabel

Testing / Reviewing

Verify of functionality is intact and changes makes sense

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 903b504
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66eaa256fac0a700081680b6
😎 Deploy Preview https://deploy-preview-17467--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 903b504
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66eaa256aff28600081160b9
😎 Deploy Preview https://deploy-preview-17467--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@riddhybansal riddhybansal added this pull request to the merge queue Sep 19, 2024
Merged via the queue into carbon-design-system:main with commit 7956f63 Sep 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aria-label is required for TableExpandHeader instead of optional
4 participants