Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove defaultProps usage #5536

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Jun 18, 2024

Closes #5032

This PR removes any usage of defaultProps which is removed in React 19. As recommended in the React 19 upgrade guide, default props are recommended to be provided as default function parameters.

What did you change?

docs/CODE_GUIDELINES.md
packages/ibm-products/src/components/AddSelect/AddSelect.tsx
packages/ibm-products/src/components/Datagrid/Datagrid/addons/CustomizeColumns/ButtonWrapper.js
packages/ibm-products/src/components/Datagrid/Datagrid/addons/RowSize/RowSizeRadioGroup.js
packages/ibm-products/src/components/Nav/NavItemLink.js

How did you test and verify your work?

  • All components still function same in storybook
  • All tests pass

@matthewgallo matthewgallo requested a review from a team as a code owner June 18, 2024 19:00
@matthewgallo matthewgallo requested review from annawen1 and amal-k-joy and removed request for a team June 18, 2024 19:00
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 09f54c0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6671e98a0a841a0008c63de1
😎 Deploy Preview https://deploy-preview-5536--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo marked this pull request as draft June 18, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove any defaultProps usage across all components
1 participant