feat: adding the ability to disable modals for TagSet component #5753
+78
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeesonjohnson
requested review from
devadula-nandan and
annawen1
and removed request for
a team
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
|
Hey @jeesonjohnson, someone will review this PR after the team has triaged the related issue (#5726). Thanks for your patience! 😄 |
|
Sounds good, thanks for the update @matthewgallo! |
devadula-nandan
added
the
needs: design opinion
|
@jeesonjohnson can you please resolve the merge conflicts? thanks! |
|
Hey @davidmenendez, gone ahead and resolved the merge conflicts. |
devadula-nandan
removed
the
needs: design opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5726
Added the ability to disable the overflow modal for additional tags. This gives consumers the customisability to use their component to manage and view tags.
What did you change?
packages/ibm-products/src/components/TagSet/TagSet.stories.jsxpackages/ibm-products/src/components/TagSet/TagSet.test.jspackages/ibm-products/src/components/TagSet/TagSet.tsxpackages/ibm-products/src/components/TagSet/TagSetOverflow.tsxHow did you test and verify your work?
Added additional unit tests
Visual testing:
Screen.Recording.2024-07-29.at.14.18.06.mov