Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): select all row count updated to exclude disabled rows #6085

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

Closes #5937

Selectable row should not count disabled rows in select all button

What did you change?

Updated the totalCount attribute being passed to TableBatchActions with only selectable rows count.

How did you test and verify your work?

Storybook

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner September 20, 2024 06:19
@sangeethababu9223 sangeethababu9223 requested review from davidmenendez and makafsal and removed request for a team September 20, 2024 06:19
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 64602a2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66ed4e6d52fc5c0008e74704
😎 Deploy Preview https://deploy-preview-6085--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datagrid]: Selectable row should not count disabled rows in select all button
1 participant