Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There aren't solutions or answers for exercises in chapter 7 #228

Closed
aturner-epcc opened this issue Jul 29, 2024 · 1 comment · Fixed by #242
Closed

There aren't solutions or answers for exercises in chapter 7 #228

aturner-epcc opened this issue Jul 29, 2024 · 1 comment · Fixed by #242
Assignees
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review

Comments

@aturner-epcc
Copy link
Contributor

Address issue raised in peer review

@aturner-epcc aturner-epcc added the peer review:editorial comment Editorial comments to be addressed from the peer review label Jul 29, 2024
@jcohen02 jcohen02 self-assigned this Jul 31, 2024
@jcohen02
Copy link
Contributor

jcohen02 commented Aug 1, 2024

I'm not sure about this one, @aturner-epcc - looking at the rendered version of the lesson, Chapter 7 is "Creating more complex container images" which is provided by advanced-containers.md.

From what I can see, all the exercises have solutions provided - they have the little "Show me the solution" drop down and solutions are provided.

The only thing I wondered is whether this point relates to the callouts with questions in them towards the top of the lesson - "Running containers" and "No such file or directory". These are added as challenge blocks but without a corresponding solution block - this in turn changes the icon to a little callout/chat symbol. In fact, the answers are then discussed below the box. I don't think it makes sense to put these answers in a "challenge/solution" block so that they have to be expanded, since I think they're intended as part of the content that the instructor works through so I think this is perhaps just more of a styling issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants