Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding solution and guidance to questions in advanced-containers.md #242

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

jcohen02
Copy link
Contributor

@jcohen02 jcohen02 commented Aug 1, 2024

This PR adds a solution to one of the questions towards the top of advanced-containers.md. The second question that didn't have a solution isn't really intended to have one since it highlights the question being answered in the next section of the material. To address this, the PR adds a note that the question is there as something to think about, with the answer worked through in the content below.

Closes #228.

Copy link

github-actions bot commented Aug 1, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-242

The following changes were observed in the rendered markdown documents:

 advanced-containers.md | 38 ++++++++++++++++++++++++++++++++++++--
 md5sum.txt             |  2 +-
 2 files changed, 37 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-01 19:52:32 +0000

@jcohen02 jcohen02 added the peer review:editorial comment Editorial comments to be addressed from the peer review label Aug 1, 2024
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Copy link
Contributor

@aturner-epcc aturner-epcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, merging...

@aturner-epcc aturner-epcc merged commit 710abbc into carpentries-incubator:main Aug 16, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Auto-generated via {sandpaper}
Source  : 710abbc
Branch  : main
Author  : Andy Turner <[email protected]>
Time    : 2024-08-16 08:20:10 +0000
Message : Merge pull request #242 from jcohen02/fix/issue228

Adding solution and guidance to questions in advanced-containers.md
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
Auto-generated via {sandpaper}
Source  : f303b4e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-08-16 08:20:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 710abbc
Branch  : main
Author  : Andy Turner <[email protected]>
Time    : 2024-08-16 08:20:10 +0000
Message : Merge pull request #242 from jcohen02/fix/issue228

Adding solution and guidance to questions in advanced-containers.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There aren't solutions or answers for exercises in chapter 7
2 participants