test(nodebuilder): disable TestArchivalBlobSync #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
vgonkivs
reviewed
Aug 8, 2024
|
Done #3636 |
walldiss
previously approved these changes
Aug 8, 2024
|
@cristaloleg we had wrapped these skips in testing.Short() before so they don't vanish completely, and CI can be run with the short flag (assuming its some resource/bootstrap constraint in ci env) but locally they still run, might be worth doing similar eg: https://github.com/celestiaorg/celestia-node/blob/main/nodebuilder/tests/reconstruct_test.go#L89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable this test for now due to its frequent failures. Will be revisited later.