Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rpc.gaspricemultiplier option #2154

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Add --rpc.gaspricemultiplier option #2154

merged 1 commit into from
Jul 7, 2023

Conversation

palango
Copy link
Contributor

@palango palango commented Jul 6, 2023

This add command line option to adjust the
multiplier in the gas price suggestion RPC
endpoint.

Example:

geth --rpc.gaspricemultiplier 1.456

Resolves #2136

Further improvements are tracked in #2153

@palango palango requested a review from gastonponti July 6, 2023 15:12
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

5841 passed, 45 skipped

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 35.71% and project coverage change: +0.03 🎉

Comparison is base (88635e4) 55.26% compared to head (b58489e) 55.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
+ Coverage   55.26%   55.30%   +0.03%     
==========================================
  Files         675      675              
  Lines      113729   113739      +10     
==========================================
+ Hits        62853    62902      +49     
+ Misses      47027    46996      -31     
+ Partials     3849     3841       -8     
Impacted Files Coverage Δ
cmd/geth/main.go 21.39% <ø> (ø)
cmd/geth/usage.go 10.90% <ø> (ø)
cmd/utils/flags.go 2.54% <0.00%> (-0.02%) ⬇️
eth/api_backend.go 0.00% <0.00%> (ø)
les/api_backend.go 0.00% <0.00%> (ø)
contracts/gasprice_minimum/gasprice_minimum.go 49.39% <100.00%> (+1.89%) ⬆️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palango palango force-pushed the palango/gas-price branch 2 times, most recently from 34d6e65 to b58489e Compare July 7, 2023 10:58
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit be7fd44

coverage: 48.4% of statements across all listed packages
coverage:  60.0% of statements in consensus/istanbul
coverage:  40.5% of statements in consensus/istanbul/announce
coverage:  54.5% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.2% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

This add command line option to adjust the
multiplier in the gas price suggestion RPC
endpoint.
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palango palango merged commit be7fd44 into master Jul 7, 2023
25 checks passed
@palango palango deleted the palango/gas-price branch July 7, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong result for eth_gasPrice
2 participants