Add CIP-66 receipt field feeInFeeCurrency #2292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Coverage from tests in coverage: 49.7% of statements across all listed packagescoverage: 63.4% of statements in consensus/istanbul coverage: 42.9% of statements in consensus/istanbul/announce coverage: 54.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 62.1% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
carterqw2
reviewed
Apr 9, 2024
core/types/receipt.go
Outdated
| FeeInFeeCurrency *big.Int | ||
| } | ||
|
|
||
| type preCIP66receiptRLP struct { |
There was a problem hiding this comment.
Maybe we should keep the old structures untouched for easier maintenance and use a specifically-typed structure for the new TX type.
There was a problem hiding this comment.
The receipt types are a bit confusing, technically here the old ones are untouched, and this one is only used for CELO denominated txs, as seen in the Receipts encode index (and decode as well).
But it's true that it feels like a weird change from this perspective
…st for CELO denominated txs to use it
hbandura
force-pushed
the
hbandura/celoden_e2e
branch
from
bd06858
to
77c1b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the receipt field for CELO denominated txs
Add e2etest for CELO denominated txs
Fix minor bugs in tx JSON marshalling
Remove e2e tests pertaining previous fork activation