Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reef/ubi9 #2131

Merged
merged 2 commits into from
Jul 17, 2023
Merged

add reef/ubi9 #2131

merged 2 commits into from
Jul 17, 2023

Conversation

guits
Copy link
Collaborator

@guits guits commented Jul 17, 2023

This adds the reef / el9 combination to the current matrix

Signed-off-by: Guillaume Abrioux [email protected]

This adds the reef / el9 combination to the current matrix

Signed-off-by: Guillaume Abrioux <[email protected]>
rename the folder `ceph-releases/quincy/ubi9` to
`ceph-releases/quincy/ubi9-redhat`. Otherwise, the override at
`ceph-releases/ALL` is taken.

Signed-off-by: Guillaume Abrioux <[email protected]>
@ktdreyer
Copy link
Member

ktdreyer commented Jul 17, 2023

I've tested this for regressions:

BRANDING=redhat VERSION=6 ./contrib/compose-rhcs.sh
BRANDING=ibm VERSION=6 ./contrib/compose-rhcs.sh

... no differences 👍

I tested the new 7 support:

BRANDING=redhat VERSION=7 ./contrib/compose-rhcs.sh
BRANDING=ibm VERSION=7 ./contrib/compose-rhcs.sh

The IBM Dockerfile still has some 6 references that we must change to 7.

@guits
Copy link
Collaborator Author

guits commented Jul 17, 2023

The IBM Dockerfile still has some 6 references that we must change to 7.

let's address this in a separate PR

@ktdreyer
Copy link
Member

Guillaume and I discussed this on Slack, and we agreed to merge this now as-is, so we can make smaller edits in future PRs.

@guits guits merged commit e6e8ddb into main Jul 17, 2023
6 checks passed
@guits guits deleted the reef-ubi9 branch July 17, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants