ubi9-ibm: unify ADD steps for reef #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "reef" template overrides the contents of the "ALL" template. As a result, prior to this change, we missed an ADD command in the generated Dockerfile. Unify and simplify the instructions so we include the proper steps for reef. Signed-off-by: Ken Dreyer <[email protected]>
ktdreyer
force-pushed
the
ibm-ceph-add
branch
from
aad85a9
to
5f9c7c9
Compare
|
Ran compose-rhcs with this and it matched the downstream Dockerfile that had both ADD lines, LGTM |
bigjust
approved these changes
Dec 6, 2023
|
@guits would you please merge this? It will avoid a regression. |
guits
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reeftemplate overrides the contents of theALLtemplate. As a result, prior to this change, we missed anADDcommand in the generatedDockerfile.Unify and simplify the instructions so we include the proper steps for
reef.