rbd: implement librbd.rbd_group_snap_get_info #1025
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
force-pushed
the
rbd/rbd_group_snap_get_info
branch
2 times, most recently
from
a40229f
to
dee055a
Compare
phlogistonjohn
added
the
API
anoopcs9
previously approved these changes
Sep 12, 2024
|
@Mergifyio rebase |
anoopcs9
force-pushed
the
rbd/rbd_group_snap_get_info
branch
from
dee055a
to
5d6c6f6
Compare
✅ Branch has been successfully rebased |
14 tasks
|
|
|
The new GroupSnapGetInfo function can be used to get a list of the RBD image snapshots that were created as part of the RBD group snapshot. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
rbd/rbd_group_snap_get_info
branch
from
5d6c6f6
to
2052bb5
Compare
mergify
bot
dismissed
anoopcs9’s stale review
Pull request has been modified.
idryomov
reviewed
Sep 20, 2024
| #include <rbd/librbd.h> | ||
|
|
||
| // exact copy of librbd.h:rbd_group_snap_namespace_type_t as it is not included in all versions | ||
| #ifndef RBD_GROUP_SNAP_NAMESPACE_TYPE_USER |
There was a problem hiding this comment.
Instead of defining the underscored versions below, could ifndef block just be extended?
There was a problem hiding this comment.
Oh, yes, that probably works too. Would make it a little cleaner. I'll try that once the Ceph PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new GroupSnapGetInfo function can be used to get a list of the RBD
image snapshots that were created as part of the RBD group snapshot.
This feature is implemented in 2 steps:
dlsymI hope that makes it easier to understand, and might help others contributing such dynamically loaded functions too.
Depends-on: ceph/ceph#59883
Checklist
//go:build ceph_previewmake api-updateto record new APIs