Refactoring code and updating Feat Plausible #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
filiptaticek
commented
Jun 25, 2023
filiptaticek
commented
- removing plausible logic from the ActionButton component
- tracking plausible when the exercise is played from the dictionary
- tracking plausible when the exercise is restarted
added 5 commits
June 18, 2023 21:09
…eConfiguration, using the onClick attribute
…ctionary as well as when it is restarted
jejdacz
reviewed
Jun 25, 2023
| <ActionButton onClickAsync={restart}>{t('exercise_page.restart') || ''}</ActionButton> | ||
| <ActionButton | ||
| onClickAsync={() => { | ||
| plausible('Exercise-Started', { props: { language: lang, length: size } }); |
There was a problem hiding this comment.
Tady posíláš celý objekt lang což je
lang: {
currentLanguage: Language;
otherLanguage: Language;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.