Features/random story and fix feedback slider #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
met
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Hi, thanks, picture resizing is fixed now. Good. 👍
I see just these problems:
- In Slovak Movapp version you show preview to fairytales that do not exist in Slovak. Check here - link cannot work https://movapp-nhlhbfqnw-ceskodigital.vercel.app/uk/kids/stories/cervena-karkulka - you need to filter and show only fairytales that exist in given language mutation.
- Sometimes you show preview if the same story that you are on (eg on story O třech prasátkách you show preview to O třech prasátkách too). We should filter that.
- On preview you have clickable only heading text, the picture should be clickable too (the same way it works in list of stories)
|
Okay, I got, will change it |
met
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
randomSlider story and fix feedback slider