Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep symbol comparison #81

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Feb 25, 2022

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @snewcomer!

My hunch is this is a minor release? We could be extra careful and release as breaking?

@snewcomer
Copy link
Contributor Author

snewcomer commented Feb 25, 2022

Seems like we support this API in chai (in 4.x and 5.x) so that seems right! Thanks a bunch for reviewing. Really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants