fix: not logging in with pushwithtag (#2643)

* fix: not logging in with pushwithtag This PR makes sure that we log in when we push an image that is being promoted. * Update artifact_builder.go * commit from cli-ci -- updated coverage * fmt --------- Co-authored-by: jakeyheath <[email protected]>
chanzuckerberg · Oct 26, 2023 · a3c467d · a3c467d
1 parent b7bdadc
commit a3c467d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/cli/COVERAGE b/cli/COVERAGE
@@ -1 +1 @@
-22.65
+22.63
diff --git a/cli/pkg/artifact_builder/COVERAGE b/cli/pkg/artifact_builder/COVERAGE
@@ -1 +1 @@
-56.7
+56.2
diff --git a/cli/pkg/artifact_builder/artifact_builder.go b/cli/pkg/artifact_builder/artifact_builder.go
@@ -566,6 +566,11 @@ func (ab ArtifactBuilder) Push(ctx context.Context, tags []string) error {
 // PushFrom allows the caller to specify where the images are coming from and also what tags
 // to pull from.
 func (ab ArtifactBuilder) PushFromWithTag(ctx context.Context, servicesImage map[string]string, tag string) error {
+	err := ab.RegistryLogin(ctx)
+	if err != nil {
+		return err
+	}
+
 	return ab.push(ctx, []string{tag}, servicesImage)
 }