feat: allow AWS account ID to change for ECR policy #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeyheath
requested review from
dtsai-czi,
alexlokshin-czi and
hspitzley-czi
and removed request for
a team
|
No Jira issue reference found in branch, title, or body of PR. Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR. |
|
No Jira issue reference found in branch, title, or body of PR. Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR. |
| @@ -24,7 +28,7 @@ module "autocreated_ecr_writer_policy" { | |||
| source = "[email protected]:chanzuckerberg/shared-infra//terraform/modules/aws-iam-policy-ecr-writer?ref=v0.125.0" | |||
| role_name = var.gh_actions_role_name | |||
| // TODO: not a super fan of this. Would be ideal to have the role only have access to the stacks created by this happy project | |||
| ecr_repository_arns = ["arn:aws:ecr:us-west-2:${data.aws_caller_identity.current.account_id}:repository/*/${var.tags.env}/*"] | |||
| ecr_repository_arns = ["arn:aws:ecr:us-west-2:${local.account_id}:repository/*/${var.tags.env}/*"] | |||
There was a problem hiding this comment.
Definitely calls for shared ecr repositories!
alexlokshin-czi
approved these changes
Oct 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCIE-2010
https://czi-tech.atlassian.net/browse/CCIE-2010?atlOrigin=eyJpIjoiNDg5ODEyMzVlMWRkNGUxMmI0Zjc2NjJiNzNiZmY0YjkiLCJwIjoiamlyYS1zbGFjay1pbnQifQ
This allows the caller to change the AWS account that the ECR lives in. If nothing is specified, it will use the current account that it i s being executed. This is helpful when we need to grant one CI role access to other happy environments.