Fix installation conditions of 'launch' files with catkin #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YoheiKakiuchi Could you check if this PR affects your software please? |
|
I made this PR ready for review, with @ssr-yuki 's consent in another chat tool. |
HansRobo
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #22 .
To guarantee the requirements discussed in #16 , this PR adds an additional condition to install the
launchdirectory:choreonoid_rosinstalls the directory only if the destination path ends withinstall, such as~/catkin_ws/install.In fact, this is an ad hoc bug fix, but I don't have any other ideas at the moment.
FYI: the following document provides the list of variables we can utilise in CMake:
http://docs.ros.org/en/melodic/api/catkin/html/user_guide/variables.html