Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple equal reactions from user are displayed multiple times #1653

Open
Kladki opened this issue Mar 24, 2024 · 0 comments · May be fixed by #1713
Open

Multiple equal reactions from user are displayed multiple times #1653

Kladki opened this issue Mar 24, 2024 · 0 comments · May be fixed by #1713
Labels
area: timeline type: bug Something isn't working

Comments

@Kladki
Copy link

Kladki commented Mar 24, 2024

Describe the bug

When multiple m.reaction events are sent from a user with the same key and rel_type from the same user, it causes their reactions to add up rather than just being displayed once. Multiple reactions can be caused by buggy clients, multiple clients reacting at the same time, or lag.
image
image

Reproduction

  1. Send a message
  2. Get the event id
  3. Use element devtools to send this event multiple times of type m.reaction:
"m.relates_to": {
  "event_id": "${event_id}",
  "key": "👍",
  "rel_type": "m.annotation"
}
  1. See issue

Expected behavior

Only one reaction of a certain emoji should be displayed for a single user.

Multiple identical annotations (i.e., with the same event type and annotation key) from the same user (i.e., events with the same sender) should be treated as a single annotation.

https://spec.matrix.org/v1.10/client-server-api/#annotations-client-behaviour

Platform and versions

- Alpine Linux edge
- Cinny destkop 2.3.1
- Conduit 0.7.0 alpha ([91764745](https://gitlab.com/famedly/conduit/-/commit/9176474513481a035c63c85b7dc6c0025b950dcf) - 2024-03-23)

Additional context

No response

@kfiven kfiven added type: bug Something isn't working area: timeline labels Mar 30, 2024
@TTTaevas TTTaevas linked a pull request Apr 28, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: timeline type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants