Do not display duplicate reactions #1713
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Duplicate reactions" in this context means reactions using the same key from the same user
As there are two places in the code from where reactions can be gotten (
Reactions.tsx
&ReactionViewer.tsx
), the code to fix the problem also appears twiceThis code ignores (disables for a line) the
no-param-reassign
ESLint rule, as I couldn't find a way to return something of type[string, Set<MatrixEvent>]
without returning the parameter itselfI must admit I don't really know if that's the right way to go about it
Fixes #1653
Type of change
Checklist: