Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display duplicate reactions #1713

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

TTTaevas
Copy link

Description

"Duplicate reactions" in this context means reactions using the same key from the same user

As there are two places in the code from where reactions can be gotten (Reactions.tsx & ReactionViewer.tsx), the code to fix the problem also appears twice
This code ignores (disables for a line) the no-param-reassign ESLint rule, as I couldn't find a way to return something of type [string, Set<MatrixEvent>] without returning the parameter itself

I must admit I don't really know if that's the right way to go about it

Fixes #1653

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Apr 28, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@TTTaevas
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple equal reactions from user are displayed multiple times
1 participant