Fix video and audio loading with authenicated media #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appeareantly Firefox (and maybe Chrome) won't let service workers take over requests from <video> and <audio> tags, so we just fetch the URL ourselves.
|
Preview: https://1946--pr-cinny.netlify.app |
ajbura
requested changes
Sep 11, 2024
| @@ -4,7 +4,8 @@ import { decryptFile } from '../../../utils/matrix'; | |||
| export const getFileSrcUrl = async ( | |||
| httpUrl: string, | |||
| mimeType: string, | |||
| encInfo?: EncryptedAttachmentInfo | |||
| encInfo?: EncryptedAttachmentInfo, | |||
| forceFetch?: boolean | |||
There was a problem hiding this comment.
This function was made to decrypt file but maybe named wrong so I think we should use different function for fetching unencrypted file as adding a boolean param make it hard to reason what this function do.
Apart from it maybe in a different PR we can later remove the line: 15 createObjectURL outside it.
There was a problem hiding this comment.
actually I think I can fix it, I am currently working on fixing the download problem and has to changed getFileSrcUrl usage as I found we already have a decryptFile function in app/utils/matrix
ajbura
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #1930, Appeareantly Firefox (and maybe Chrome) won't let service workers take over requests from
Fixes #1818 (comment)
Type of change
Checklist: