Add Clerk Express SDK docs #1201
Conversation
docs/manifest.json
Outdated
| { | ||
| "title": "Express.js", | ||
| "collapse": true, | ||
| "icon": "nodejs", |
There was a problem hiding this comment.
🔧 I think we should add and use an expressjs icon. You have already defined it in manifest.schema.json. The icon need to be added in the marketing site (check PR)
There was a problem hiding this comment.
I've already talked with the design team to create an svg icon.
There was a problem hiding this comment.
@alexisintech Why did we dismiss this review? We are still using the nodejs svg but we should update it.
There was a problem hiding this comment.
@EmmanouelaPothitou any update on the svg icon ?
There was a problem hiding this comment.
I think this should be merged before this pr.
EmmanouelaPothitou
force-pushed
the
emmanouela/sdk-1694-stable-release-of-clerkexpress
branch
from
c12e98b
to
472d339
Compare
|
please tag me to fully review once all the content is verified as correct by the other reviewers ! |
alexisintech
requested review from
alexisintech
and removed request for
alexisintech
EmmanouelaPothitou
force-pushed
the
emmanouela/sdk-1694-stable-release-of-clerkexpress
branch
2 times, most recently
from
e8f92b1
to
2ab9557
Compare
|
What is |
|
@alexisintech it's a new export that's only included in the |
| @@ -0,0 +1,104 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think maybe putting this under upgrade guides might make more sense
There was a problem hiding this comment.
Aren't upgrade guides meant to be related to major Clerk upgrades? I think that we should keep it here since it's specific to the Clerk express package and how you can use it if you are already using the @clerk/clerk-sdk-node package.
|
Hey, here’s your docs preview: https://clerk.com/docs/pr/1201 |
alexisintech
changed the title
docs/manifest.json
Outdated
| { | ||
| "title": "Express.js", | ||
| "collapse": true, | ||
| "icon": "nodejs", |
There was a problem hiding this comment.
@alexisintech Why did we dismiss this review? We are still using the nodejs svg but we should update it.
| @@ -0,0 +1,104 @@ | |||
| --- | |||
There was a problem hiding this comment.
Aren't upgrade guides meant to be related to major Clerk upgrades? I think that we should keep it here since it's specific to the Clerk express package and how you can use it if you are already using the @clerk/clerk-sdk-node package.
This is a major upgrade imo. We're deprecating the sdk-node package, and anyone using the sdk-node package needs to migrate over to a completely different package that is massively breaking. I think this is the appropriate place for such a guide. |
…fix getauth example
wobsoriano
force-pushed
the
emmanouela/sdk-1694-stable-release-of-clerkexpress
branch
from
0c67602
to
a18f034
Compare
|
Hi team, I've updated the PR with some clean-ups and added a quickstart page for the Express SDK. I think it's ready for review! Thanks all |
Create documentation for the Express SDK and a guide for migrating from the Node SDK to Express SDK
Important
🔎 Previews: