Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM ABI: implement row_iter_bsatn_advance & row_iter_bsatn_close #1622

Merged
merged 1 commit into from
Aug 27, 2024
Merged

WASM ABI: implement row_iter_bsatn_advance & row_iter_bsatn_close #1622

merged 1 commit into from
Aug 27, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 21, 2024 •
edited
Loading

Description of Changes

Implements row_iter_bsatn_advance & row_iter_bsatn_close.

cc #1460

@Centril Centril changed the base branch from master to centril/bytes-sink-write August 21, 2024 10:10
RReverser
RReverser reviewed Aug 21, 2024
View reviewed changes
crates/bindings-csharp/Runtime/Internal/ITable.cs Outdated Show resolved Hide resolved
crates/bindings-csharp/Runtime/Internal/ITable.cs Outdated Show resolved Hide resolved
crates/bindings-csharp/Runtime/Internal/ITable.cs Outdated Show resolved Hide resolved
crates/bindings-csharp/Runtime/Internal/ITable.cs Outdated Show resolved Hide resolved
crates/bindings/src/rt.rs Show resolved Hide resolved
crates/core/src/host/wasmtime/wasm_instance_env.rs Show resolved Hide resolved
crates/bindings-csharp/Runtime/Internal/ITable.cs Show resolved Hide resolved
@Centril Centril force-pushed the centril/row-iter-bsatn-advance branch from ed025b2 to 520b9d0 Compare August 21, 2024 15:12
@Centril Centril force-pushed the centril/bytes-sink-write branch 2 times, most recently from 8e26b2c to 3e45a7a Compare August 21, 2024 18:03
@Centril Centril force-pushed the centril/row-iter-bsatn-advance branch from c23d960 to 8dd9187 Compare August 21, 2024 18:04
@Centril Centril force-pushed the centril/row-iter-bsatn-advance branch 5 times, most recently from 9f54e9d to d21e499 Compare August 22, 2024 20:47
@Centril Centril force-pushed the centril/row-iter-bsatn-advance branch from 9b0f453 to b62234a Compare August 26, 2024 08:31
@Centril Centril added abi-break A PR that makes an ABI breaking change release-0.12 labels Aug 26, 2024
@Centril Centril mentioned this pull request Aug 27, 2024
Open
@Centril Centril changed the base branch from centril/bytes-sink-write to master August 27, 2024 16:02
@Centril Centril force-pushed the centril/row-iter-bsatn-advance branch from b62234a to ae0b238 Compare August 27, 2024 21:47
@Centril Centril enabled auto-merge August 27, 2024 21:48
@Centril Centril added this pull request to the merge queue Aug 27, 2024
Merged via the queue into master with commit 1dd1e63 Aug 27, 2024
8 checks passed
@Centril Centril deleted the centril/row-iter-bsatn-advance branch August 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RReverser RReverser RReverser approved these changes

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
abi-break A PR that makes an ABI breaking change release-0.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Centril @RReverser @coolreader18