Review feedback

clockworklabs · Sep 19, 2024 · 8468e56 · 8468e56
1 parent 521ef70
commit 8468e56
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/examples~/quickstart/client/module_bindings/_Globals/SpacetimeDBClient.cs b/examples~/quickstart/client/module_bindings/_Globals/SpacetimeDBClient.cs
@@ -23,6 +23,8 @@ public sealed class RemoteTables
 
 	public sealed class RemoteReducers : RemoteBase<DbConnection>
 	{
+		internal RemoteReducers(DbConnection conn) : base(conn) {}
+
 		public delegate void SendMessageHandler(EventContext ctx, string text);
 		public event SendMessageHandler? OnSendMessage;
 
@@ -73,11 +75,11 @@ public partial class EventContext : EventContextBase<RemoteTables, RemoteReducer
 	public class DbConnection : DbConnectionBase<DbConnection, EventContext>
 	{
 		public readonly RemoteTables RemoteTables = new();
-		public readonly RemoteReducers RemoteReducers = new();
+		public readonly RemoteReducers RemoteReducers;
 
 		public DbConnection()
 		{
-			RemoteReducers.Init(this);
+			RemoteReducers = new(this);
 
 			clientDB.AddTable<Message>();
 			clientDB.AddTable<User>();

diff --git a/examples~/quickstart/client/spacetimedb-quickstart-client-cs.csproj b/examples~/quickstart/client/spacetimedb-quickstart-client-cs.csproj
@@ -11,8 +11,6 @@
 
   <ItemGroup>
     <ProjectReference Include="../../../SpacetimeDB.ClientSDK.csproj" />
-    <ProjectReference Include="..\..\..\..\stdb-module-cs\crates\bindings-csharp\BSATN.Codegen\BSATN.Codegen.csproj"  OutputItemType="Analyzer" />
-    <ProjectReference Include="..\..\..\..\stdb-module-cs\crates\bindings-csharp\BSATN.Runtime\BSATN.Runtime.csproj" />
   </ItemGroup>
 
 </Project>
diff --git a/src/SpacetimeDBClient.cs b/src/SpacetimeDBClient.cs
@@ -160,7 +160,7 @@ struct ProcessedMessage
             public ServerMessage message;
             public List<DbOp> dbOps;
             public DateTime timestamp;
-            public EventContext reducerEvent;
+            public EventContext? reducerEvent;
         }
 
         struct PreProcessedMessage

diff --git a/src/Stubs.cs b/src/Stubs.cs
@@ -48,7 +48,7 @@ public EventContextBase(RemoteTables db, RemoteReducers reducers, TransactionUpd
     }
 
     public abstract class RemoteBase<DbConnection> {
-        protected DbConnection conn;
+        protected readonly DbConnection conn;
 
         protected RemoteBase(DbConnection conn) {
             this.conn = conn;