Date filter, logging and types #26
Conversation
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
speaking of, I see there are unit tests in a workflow. But I don't see it running on this pr. Is the workflow run part properly configured? |
|
Unit tests are performed on push, in the fork branch as of now, we can configure it to run for pull requests too. |
|
@shashank-boyapally do you see the test results on your fork then? I think it would be more helpful to show that result in the PR itself so we can know if everything is passing before merge |
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
Signed-off-by: Shashank Reddy Boyapally <[email protected]>
| meta["networkType"] = "OVNKubernetes" | ||
| meta["benchmark.keyword"] = "cluster-density-v2" | ||
| # meta['encrypted'] = "true" | ||
| # meta['ipsec'] = "false" | ||
| # meta['fips'] = "false" | ||
|
|
||
| uuids = match.get_uuid_by_metadata(meta) | ||
| print("All uuids",len(uuids)) |
There was a problem hiding this comment.
Are these just debugs?
There was a problem hiding this comment.
yep this is just a utility for functionality testing.
| import sys | ||
|
|
||
|
|
||
| class SingletonLogger: |
There was a problem hiding this comment.
I don't think we need a singleton class here. It just as simple as updating a config.
There was a problem hiding this comment.
Thank you for the suggestion. The thought behind this was as follows: having a logger setup in Matcher class created duplicate logs of the same log-output, especially in daemon mode where multiple Matcher objects would be created as when the request would come in and multiple formatters were being attached to the logger which led to duplicate logs. To mitigate this a temporary solution was to check if the logger existed previously. I transferred this logic to a class so that it can be used in Orion as well. The SingletonLogger here also updates the config using methods and also keeps track of only having a single logger.
There was a problem hiding this comment.
logging is singleton by default. All I am saying is, I think we need not write a custom logging class instead of just using the existing ones.
| "ignore", category=UserWarning, message=".*Connecting to.*verify_certs=False.*" | ||
| ) | ||
|
|
||
| match = Matcher(index="perf_scale_ci*", verify_certs=False) |
There was a problem hiding this comment.
Do we want to change it to ospst-* as well?
There was a problem hiding this comment.
Currently this utility works on the qe instance...
There was a problem hiding this comment.
Nope - as that would require having access to internal resources.
| if len(uuids) == 0: | ||
| print("No UUID present for given metadata") | ||
| sys.exit() | ||
| runs = match.match_kube_burner(uuids) | ||
| runs = match.match_kube_burner(uuids,"ripsaw-kube-burner*") |
There was a problem hiding this comment.
Same here as well ospst-*
Type of change
Description
Added logging for common usage, date filter for orion's new feature of lookback and types to methods
Related Tickets & Documents
Checklist before requesting a review
Testing